Remove frame ID from DidCommitProvisionalLoad.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 5a712ff70fb765f1d1ff3bd3ab899cac142567b8..d2f712142f9c8786a538cc9e6db8402a69d6baf7 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2103,18 +2103,18 @@ void WebContentsImpl::DidRedirectProvisionalLoad(
 }
 
 void WebContentsImpl::DidCommitProvisionalLoad(
-    int64 frame_id,
+    RenderFrameHostImpl* render_frame_host,
     const base::string16& frame_unique_name,
     bool is_main_frame,
     const GURL& url,
-    PageTransition transition_type,
-    RenderFrameHostImpl* render_frame_host) {
+    PageTransition transition_type) {
   RenderViewHost* render_view_host = render_frame_host->render_view_host();
+  int render_frame_id = render_frame_host->GetRoutingID();

[Charlie Reis, 2014/03/03 07:14:50]

Nasko: I changed this to store the render_frame_id outside the observer loop
because of these failures in SigninSkipForNowAndGoBack:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...

Looks like you added that test in
https://chromiumcodereview.appspot.com/19699007, and it's deleting
|render_frame_host| as we iterate through the observers.  The test passes again
so this CL is safe, but we may want to revisit how that test works if possible.

[nasko, 2014/03/03 15:01:22]

The test will likely be removed as the old style signin code is phased out.

   // Notify observers about the commit of the provisional load.
   FOR_EACH_OBSERVER(
       WebContentsObserver,
       observers_,
-      DidCommitProvisionalLoadForFrame(frame_id,
+      DidCommitProvisionalLoadForFrame(render_frame_id,
                                        frame_unique_name,
                                        is_main_frame,
                                        url,