Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 635543d9d0fad61c1e845d752e9fee62c01e56fb..16dd8cc93e3138183681a4903ba03083d14938c7 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -303,7 +303,7 @@ TEST_F(WebContentsImplTest, UpdateTitle) {
InitNavigateParams(&params, 0, GURL(kAboutBlankURL), PAGE_TRANSITION_TYPED);
LoadCommittedDetails details;
- cont.RendererDidNavigate(test_rvh(), params, &details);
+ cont.RendererDidNavigate(main_test_rfh(), params, &details);
contents()->UpdateTitle(rvh(), 0,
base::ASCIIToUTF16(" Lots O' Whitespace\n"),
@@ -350,7 +350,7 @@ TEST_F(WebContentsImplTest, NTPViewSource) {
FrameHostMsg_DidCommitProvisionalLoad_Params params;
InitNavigateParams(&params, 0, kGURL, PAGE_TRANSITION_TYPED);
LoadCommittedDetails details;
- cont.RendererDidNavigate(test_rvh(), params, &details);
+ cont.RendererDidNavigate(main_test_rfh(), params, &details);
// Also check title and url.
EXPECT_EQ(base::ASCIIToUTF16(kUrl), contents()->GetTitle());
}

Powered by Google App Engine
This is Rietveld 408576698