content/browser/web_contents/web_contents_impl.h - Issue 182713005: Remove frame ID from DidCommitProvisionalLoad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index af604bc9644191a1c1af123e898c5ff6ec5a83ce..bd7e039dbcd19fb63096f744a8289fe844635458 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -467,12 +467,11 @@ class CONTENT_EXPORT WebContentsImpl

RenderFrameHostImpl* render_frame_host,

const GURL& validated_target_url) OVERRIDE;

virtual void DidCommitProvisionalLoad(

- int64 frame_id,

+ RenderFrameHostImpl* render_frame_host,

const base::string16& frame_unique_name,

bool is_main_frame,

const GURL& url,

- PageTransition transition_type,

- RenderFrameHostImpl* render_frame_host) OVERRIDE;

+ PageTransition transition_type) OVERRIDE;

virtual void DidNavigateMainFramePostCommit(

const LoadCommittedDetails& details,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params) OVERRIDE;