Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: content/public/browser/render_frame_host.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_frame_host.h
diff --git a/content/public/browser/render_frame_host.h b/content/public/browser/render_frame_host.h
index 0a56349141aa023cdb2e775c12362875f0d3b7e6..b661a1ab43635ea96e06327ce0e806bb31e61daf 100644
--- a/content/public/browser/render_frame_host.h
+++ b/content/public/browser/render_frame_host.h
@@ -27,14 +27,17 @@ class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,
virtual ~RenderFrameHost() {}
+ // Returns the route id for this frame.
+ virtual int GetRoutingID() = 0;
jam 2014/03/03 16:08:04 nit: if you're changing this order, please also up
Charlie Reis 2014/03/03 17:05:23 I already did, right? Or did I put it in the wron
+
+ // Returns the SiteInstance grouping all RenderFrameHosts that have script
+ // access to this RenderFrameHost, and must therefore live in the same
+ // process.
virtual SiteInstance* GetSiteInstance() = 0;
// Returns the process for this frame.
virtual RenderProcessHost* GetProcess() = 0;
- // Returns the route id for this frame.
- virtual int GetRoutingID() = 0;
-
// Returns the current RenderFrameHost of the parent frame, or NULL if there
// is no parent. The result may be in a different process than the current
// RenderFrameHost.

Powered by Google App Engine
This is Rietveld 408576698