Remove frame ID from DidCommitProvisionalLoad.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 2085 matching lines @@
     const GURL& validated_target_url) {
   // Notify observers about the provisional change in the main frame URL.
   FOR_EACH_OBSERVER(
       WebContentsObserver,
       observers_,
       ProvisionalChangeToMainFrameUrl(validated_target_url,
                                       render_frame_host));
 }
 
 void WebContentsImpl::DidCommitProvisionalLoad(
-    int64 frame_id,
+    RenderFrameHostImpl* render_frame_host,
     const base::string16& frame_unique_name,
     bool is_main_frame,
     const GURL& url,
-    PageTransition transition_type,
-    RenderFrameHostImpl* render_frame_host) {
+    PageTransition transition_type) {
   RenderViewHost* render_view_host = render_frame_host->render_view_host();
+  int render_frame_id = render_frame_host->GetRoutingID();

[Charlie Reis, 2014/03/03 07:14:50]

Nasko: I changed this to store the render_frame_id outside the observer loop
because of these failures in SigninSkipForNowAndGoBack:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...

Looks like you added that test in
https://chromiumcodereview.appspot.com/19699007, and it's deleting
|render_frame_host| as we iterate through the observers.  The test passes again
so this CL is safe, but we may want to revisit how that test works if possible.

[nasko, 2014/03/03 15:01:22]

The test will likely be removed as the old style signin code is phased out.

   // Notify observers about the commit of the provisional load.
   FOR_EACH_OBSERVER(
       WebContentsObserver,
       observers_,
-      DidCommitProvisionalLoadForFrame(frame_id,
+      DidCommitProvisionalLoadForFrame(render_frame_id,
                                        frame_unique_name,
                                        is_main_frame,
                                        url,
                                        transition_type,
                                        render_view_host));
 }
 
 void WebContentsImpl::DidNavigateMainFramePostCommit(
     const LoadCommittedDetails& details,
     const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {
@@ skipping 1516 matching lines @@
 
 void WebContentsImpl::OnPreferredSizeChanged(const gfx::Size& old_size) {
   if (!delegate_)
     return;
   const gfx::Size new_size = GetPreferredSize();
   if (new_size != old_size)
     delegate_->UpdatePreferredSize(this, new_size);
 }
 
 }  // namespace content