MD Settings: Lazy-load sub-pages.

MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
Committed: https://crrev.com/cecbc0485f9aa102a0f299978f81d47bffc6536f
Cr-Commit-Position: refs/heads/master@{#384245}

[michaelpg, 2016-03-22 23:35:40]

Description was changed from

==========
MD Settings: Lazy-load sub-pages.

BUG=
==========

to

==========
MD Settings: Lazy-load sub-pages.

NOCOMMIT=true
TODO: cleanup
TODO: check whether preserve-content has perf impact, if so switch to _content
:'(
TODO: publish stats

BUG=
==========

[michaelpg, 2016-03-23 19:16:13]

Description was changed from

==========
MD Settings: Lazy-load sub-pages.

NOCOMMIT=true
TODO: cleanup
TODO: check whether preserve-content has perf impact, if so switch to _content
:'(
TODO: publish stats

BUG=
==========

to

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" preserve-content name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Stats (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

[michaelpg, 2016-03-23 19:16:13]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org, kschaaf@google.com, sorvell@google.com,
tommycli@chromium.org

[michaelpg, 2016-03-23 19:16:13]

michaelpg@chromium.org changed required reviewers:
+ dbeam@chromium.org, tommycli@chromium.org

[michaelpg, 2016-03-23 19:17:51]

Description was changed from

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" preserve-content name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Stats (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

to

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" preserve-content name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

[michaelpg, 2016-03-23 19:57:05]

Dan/Tommy: Please review or divide amongst yourselves as you see fit.

Kevin/Steve: Please make sure this isn't silly :-)

The relevant bits are in settings_animated_pages.js. See
privacy_page.html for a usage example.

[tommycli, 2016-03-24 19:14:50]

michealpg:

This is fantastic work. It'd be a great thing for subpages to be loaded
on-demand. A few high level Qs:

1. Why is there an asymmetry between the "main" page and the subpages? Is this
to optimize load time for the main page?

2. Does navigating directly to a subpage via URL still work?

3. Can we make the dom-if within the settings-subpage element? It would be more
idiot proof if a user did not have to use the custom dom-if[name] syntax and
just used settings-subpage without needing to know about the on-demand loading
stuff at all.

Tommy

[michaelpg, 2016-03-24 19:56:30]

On 2016/03/24 19:14:50, tommycli wrote:
> michealpg:
> 
> This is fantastic work. It'd be a great thing for subpages to be loaded
> on-demand. A few high level Qs:
> 
> 1. Why is there an asymmetry between the "main" page and the subpages? Is this
> to optimize load time for the main page?

Kind of; this CL addresses the common case where a top-level page is shown
(meaning the "main" page of each section is shown).

We can also wrap the main pages in dom-if's to also optimize the case of
navigating directly to a sub-page, but those dom-if's will likely slow down the
common case above without some thought, so it should be considered separately.

> 
> 2. Does navigating directly to a subpage via URL still work?

Yep!

> 
> 3. Can we make the dom-if within the settings-subpage element? It would be
more
> idiot proof if a user did not have to use the custom dom-if[name] syntax and
> just used settings-subpage without needing to know about the on-demand loading
> stuff at all.

Unfortunately, this isn't possible AFAICT. The <template is="dom-if"> causes the
HTML within it not to be rendered until the the template is stamped, so it's
necessary there. If we move the <template is="dom-if"> into settings-subpage,
e.g.:

  <template is="dom-if"><content></content></template>

the HTML we want to lazy-load is no longer hidden inside a template -- it's
rendered normally, and then would be inserted the dom-if via content
redistribution (which isn't helpful).

I tried making it slightly simpler for the user by creating a custom element
that extends "template", similar to dom-if, that also includes the
settings-subpage stuff, but that requires copying a lot of code from Polymer's
"dom-if.html".

> 
> Tommy

[tommycli, 2016-03-24 21:05:29]

On 2016/03/24 19:56:30, michaelpg wrote:
> On 2016/03/24 19:14:50, tommycli wrote:
> > michealpg:
> > 
> > This is fantastic work. It'd be a great thing for subpages to be loaded
> > on-demand. A few high level Qs:
> > 
> > 1. Why is there an asymmetry between the "main" page and the subpages? Is
this
> > to optimize load time for the main page?
> 
> Kind of; this CL addresses the common case where a top-level page is shown
> (meaning the "main" page of each section is shown).
> 
> We can also wrap the main pages in dom-if's to also optimize the case of
> navigating directly to a sub-page, but those dom-if's will likely slow down
the
> common case above without some thought, so it should be considered separately.
> 
> > 
> > 2. Does navigating directly to a subpage via URL still work?
> 
> Yep!
> 
> > 
> > 3. Can we make the dom-if within the settings-subpage element? It would be
> more
> > idiot proof if a user did not have to use the custom dom-if[name] syntax and
> > just used settings-subpage without needing to know about the on-demand
loading
> > stuff at all.
> 
> Unfortunately, this isn't possible AFAICT. The <template is="dom-if"> causes
the
> HTML within it not to be rendered until the the template is stamped, so it's
> necessary there. If we move the <template is="dom-if"> into settings-subpage,
> e.g.:
> 
>   <template is="dom-if"><content></content></template>
> 
> the HTML we want to lazy-load is no longer hidden inside a template -- it's
> rendered normally, and then would be inserted the dom-if via content
> redistribution (which isn't helpful).
> 
> I tried making it slightly simpler for the user by creating a custom element
> that extends "template", similar to dom-if, that also includes the
> settings-subpage stuff, but that requires copying a lot of code from Polymer's
> "dom-if.html".
> 
> > 
> > Tommy

michealpg, thanks for addressing Questions 1 and 2. Those are good answers.


Regarding #3, it's truly sad that we can't do <template
is="dom-if"><content></content></template>. I like this CL in general, I just
don't like the fact that we can't encapsulate the dom-if complexity.

[Dan Beam, 2016-03-25 03:21:59]

can you write a test to check that thing are (and aren't) rendered as expected?

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:74:
if (!this._queuedRouteChange)
shouldn't this be queuedRouteChange_?
                                   ^

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:89:
this._queuedRouteChange.newRoute = newRoute;
nit:

this.queuedRouteChange_ = this.queuedRouteChange_ || {oldRoute: oldRoute};
this.queuedRouteChange_.newRoute = newRoute;

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:139:
template.render();
why is this better than using the standard declarative binding?  i.e.
if="[[ensureSubpageInstance_(...)]]"?

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_settings_category.js
(right):

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_settings_category.js:140:
settings.SiteSettingsPrefsBrowserProxyImpl.getInstance()
why was this necessary?

[Dan Beam, 2016-03-25 03:22:40]

also, did you mean to use [preserve-content] or do you need to update your CL
description?

[michaelpg, 2016-03-28 17:23:05]

Description was changed from

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" preserve-content name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

to

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

[michaelpg, 2016-03-29 22:02:45]

On 2016/03/25 03:22:40, Dan Beam wrote:
> also, did you mean to use [preserve-content] or do you need to update your CL
> description?

no, preserve-content won't work. updated the description.

[michaelpg, 2016-03-29 22:04:03]

addressed comments and added test. sorry for the mess,
should have rebased separately!

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:74:
if (!this._queuedRouteChange)
On 2016/03/25 03:21:59, Dan Beam wrote:
> shouldn't this be queuedRouteChange_?
>                                    ^

Done.

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:89:
this._queuedRouteChange.newRoute = newRoute;
On 2016/03/25 03:21:59, Dan Beam wrote:
> nit:
> 
> this.queuedRouteChange_ = this.queuedRouteChange_ || {oldRoute: oldRoute};
> this.queuedRouteChange_.newRoute = newRoute;

Done.

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:139:
template.render();
On 2016/03/25 03:21:59, Dan Beam wrote:
> why is this better than using the standard declarative binding?  i.e.
> if="[[ensureSubpageInstance_(...)]]"?

for declarative binding, we'd have to define ensureSubpageInstance on every
section element (which we could do with a new behavior, but would still mean
taking responsibility away from settings-animated-pages).

also, the template content needs to be created before setting
this.$.animatedPages.selected (in currentRouteChanged). we can't guarantee that
declaratively without jumping through weird async hoops.

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_settings_category.js
(right):

https://codereview.chromium.org/1826683002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_settings_category.js:140:
settings.SiteSettingsPrefsBrowserProxyImpl.getInstance()
On 2016/03/25 03:21:59, Dan Beam wrote:
> why was this necessary?

when navigating to site-settings directly, this is now called before ready, so
the BrowserProxy hasn't been created yet, so this throws.

fwiw, i'm not 100% sure site settings works cuz there are bugs in site settings
before my patch.

[Dan Beam, 2016-03-30 03:44:28]

lgtm otherwise

https://codereview.chromium.org/1826683002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1826683002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/privacy_page/privacy_page.html:219:
</template>
wat

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
File chrome/test/data/webui/settings/settings_page_browsertest.js (right):

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
chrome/test/data/webui/settings/settings_page_browsertest.js:84:
verifySectionSubpageVisibilities: function(section) {
verifySubpagesHidden or verifySectionSubpagesHidden or verifySubpagesLazy

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
chrome/test/data/webui/settings/settings_page_browsertest.js:92:
children.filter(element => element.tagName != 'TEMPLATE');
hope the linter doesn't whine

[michaelpg, 2016-03-30 22:48:02]

michaelpg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[michaelpg, 2016-03-30 22:48:02]

michaelpg@chromium.org changed required reviewers:
- tommycli@chromium.org

[michaelpg, 2016-03-30 22:48:03]

dbeam changes and some bug fixes.

+stevenjb for internet change, assuming the browser proxy
stuff will be created later

-tommycli from required reviewers because OOO

https://codereview.chromium.org/1826683002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1826683002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/privacy_page/privacy_page.html:219:
</template>
On 2016/03/30 03:44:27, Dan Beam wrote:
> wat

good catch, done

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
File chrome/test/data/webui/settings/settings_page_browsertest.js (right):

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
chrome/test/data/webui/settings/settings_page_browsertest.js:84:
verifySectionSubpageVisibilities: function(section) {
On 2016/03/30 03:44:28, Dan Beam wrote:
> verifySubpagesHidden or verifySectionSubpagesHidden or verifySubpagesLazy

Done.

https://codereview.chromium.org/1826683002/diff/100001/chrome/test/data/webui...
chrome/test/data/webui/settings/settings_page_browsertest.js:92:
children.filter(element => element.tagName != 'TEMPLATE');
On 2016/03/30 03:44:27, Dan Beam wrote:
> hope the linter doesn't whine

apparently the linter only applies to chrome/browser/*, so it excludes ui/webui
and chrome/test... whatever, changed here.

[stevenjb, 2016-03-30 22:51:42]

nice. internet lgtm. (I'll plan to improve how we access networkingPrivate in a
follow-up).

[michaelpg, 2016-03-30 23:55:09]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-03-30 23:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1826683002/#ps120002
(title: "rebase")

[commit-bot: I haz the power, 2016-03-30 23:55:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/120002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/120002

[commit-bot: I haz the power, 2016-03-31 00:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 00:49:41]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-03-31 01:35:04]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-03-31 01:35:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/120002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/120002

[michaelpg, 2016-03-31 01:37:31]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2016-03-31 01:59:23]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-03-31 01:59:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1826683002/#ps150001
(title: "flush to prepare light DOM")

[commit-bot: I haz the power, 2016-03-31 01:59:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/150001

[michaelpg, 2016-03-31 02:00:21]

https://codereview.chromium.org/1826683002/diff/150001/chrome/test/data/webui...
File chrome/test/data/webui/settings/device_page_tests.js (right):

https://codereview.chromium.org/1826683002/diff/150001/chrome/test/data/webui...
chrome/test/data/webui/settings/device_page_tests.js:62: Polymer.dom.flush();
Without this, the light DOM observer isn't called until after a setTimeout. I
think this is because Polymer's observeNodes uses a debouncer to call its
listeners.

[Dan Beam, 2016-03-31 04:25:23]

still lgtm

[commit-bot: I haz the power, 2016-03-31 08:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 08:01:22]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[michaelpg, 2016-03-31 09:22:58]

Patchset #10 (id:170001) has been deleted

[michaelpg, 2016-03-31 09:23:09]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-03-31 09:23:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1826683002/#ps150001
(title: "flush to prepare light DOM")

[commit-bot: I haz the power, 2016-03-31 09:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/150001

[michaelpg, 2016-03-31 09:33:59]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2016-03-31 09:35:05]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-03-31 09:35:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1826683002/#ps190001
(title: "closure")

[commit-bot: I haz the power, 2016-03-31 09:35:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/190001

[commit-bot: I haz the power, 2016-03-31 10:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 10:25:05]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-03-31 10:30:57]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-03-31 10:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826683002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826683002/190001

[commit-bot: I haz the power, 2016-03-31 11:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 11:32:20]

Failed to apply patch for
chrome/browser/resources/settings/settings_page/settings_subpage.html:
While running git apply --index -3 -p1;
  error:
chrome/browser/resources/settings/settings_page/settings_subheader.html: does
not exist in index

Patch:   NR 
chrome/browser/resources/settings/settings_page/settings_subheader.html->chrome/browser/resources/settings/settings_page/settings_subpage.html
Index: chrome/browser/resources/settings/settings_page/settings_subpage.html
diff --git
a/chrome/browser/resources/settings/settings_page/settings_subheader.html
b/chrome/browser/resources/settings/settings_page/settings_subpage.html
similarity index 70%
rename from
chrome/browser/resources/settings/settings_page/settings_subheader.html
rename to chrome/browser/resources/settings/settings_page/settings_subpage.html
index
ad3f437d7c673f95b25f9e29e6883e8862952e8b..8aa490ed31a1fbc36052fb388777aace6198f3b2
100644
--- a/chrome/browser/resources/settings/settings_page/settings_subheader.html
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html
@@ -1,9 +1,11 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
+<link rel="import"
href="chrome://resources/polymer/v1_0/iron-resizable-behavior/iron-resizable-behavior.html">
+<link rel="import"
href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable-behavior.html">
+<link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
 
-<dom-module id="settings-subheader">
+<dom-module id="settings-subpage">
   <template>
     <style include="settings-shared">
       :host {
@@ -33,6 +35,7 @@
       </paper-icon-button>
       <h2>[[pageTitle]]</h2>
     </div>
+    <content></content>
   </template>
-  <script src="settings_subheader.js"></script>
+  <script src="settings_subpage.js"></script>
 </dom-module>

[commit-bot: I haz the power, 2016-03-31 11:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 11:32:49]

Description was changed from

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS		
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348
==========

to

==========
MD Settings: Lazy-load sub-pages.

chrome://md-settings consists of two Pages: Basic and Advanced. Each Page
is composed of Sections (appearance, language, users, etc.).

Some Sections have additional Subpages "behind" them; these Subpages
can be opened by expanding the Section to fill the Page and presenting
the Subpage in place of the main Section contents.

This CL prevents these Subpages from being created until they are displayed.

* Rename settings-subheader to settings-subpage, make it
  NeonAnimatable, and use it to wrap the actual page.

* Place these sub-pages inside <template is="dom-if">s.

* Rework settings-animated-pages to manage the "if" setting
  of these templates.

TL;DR: instead of

    <neon-animatable name="some-page">
      <settings-subheader></settings-subheader>
      <some-page></some-page>
    </neon-animatable>

do

    <template is="dom-if" name="some-page">
      <settings-subpage>
        <some-page></some-page>
      </settings-subpage>
    </template>

Load time in milliseconds (on my Goobuntu Z840):

		Linux			Chrome OS
		Basic	Advanced	Basic	Advanced
Before (ToT)	2013	3310		3825	3651
After (this)	1649	1726		2317	2156

BUG=597348

Committed: https://crrev.com/cecbc0485f9aa102a0f299978f81d47bffc6536f
Cr-Commit-Position: refs/heads/master@{#384245}
==========

[commit-bot: I haz the power, 2016-03-31 11:32:50]

Patchset 10 (id:??) landed as
https://crrev.com/cecbc0485f9aa102a0f299978f81d47bffc6536f
Cr-Commit-Position: refs/heads/master@{#384245}