Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns
Patch Set: closure Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_subpage.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_subheader.js b/chrome/browser/resources/settings/settings_page/settings_subpage.js
similarity index 54%
rename from chrome/browser/resources/settings/settings_page/settings_subheader.js
rename to chrome/browser/resources/settings/settings_page/settings_subpage.js
index 4f702c53e0179a407023ed1b91997dc2bec0402b..397e89addb82ae525d02da1d5539b4da745a95d3 100644
--- a/chrome/browser/resources/settings/settings_page/settings_subheader.js
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.js
@@ -1,20 +1,26 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/**
* @fileoverview
- * 'settings-subheader' shows a subheader for subpages. This header contains
+ * 'settings-subpage' shows a subpage beneath a subheader. The header contains
* the subpage title and a back icon. The back icon fires an event which
* is caught by settings-animated-pages, so it requires no separate handling.
- *
- * Examples:
- *
- * <settings-subheader i18n-values="page-title:internetPageTitle">
- * </settings-subheader>
*/
+
Polymer({
- is: 'settings-subheader',
+ is: 'settings-subpage',
+
+ behaviors: [
+ // TODO(michaelpg): phase out NeonAnimatableBehavior.
+ Polymer.NeonAnimatableBehavior,
+ Polymer.IronResizableBehavior,
+ ],
+
+ properties: {
+ pageTitle: String,
+ },
/** @private */
onTapBack_: function() {

Powered by Google App Engine
This is Rietveld 408576698