chrome/browser/resources/settings/settings_page/settings_subpage.html - Issue 1826683002: MD Settings: Lazy-load sub-pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns

Patch Set: closure Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_subheader.js ('k') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_subheader.html b/chrome/browser/resources/settings/settings_page/settings_subpage.html

similarity index 70%

rename from chrome/browser/resources/settings/settings_page/settings_subheader.html

rename to chrome/browser/resources/settings/settings_page/settings_subpage.html

index ad3f437d7c673f95b25f9e29e6883e8862952e8b..8aa490ed31a1fbc36052fb388777aace6198f3b2 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subheader.html

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html

@@ -1,9 +1,11 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior/iron-resizable-behavior.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable-behavior.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">

-<dom-module id="settings-subheader">

+<dom-module id="settings-subpage">

:host {

@@ -33,6 +35,7 @@

</paper-icon-button>

<h2>[[pageTitle]]</h2>

</div>

+ <content></content>

</template>

- <script src="settings_subheader.js"></script>

+ <script src="settings_subpage.js"></script>

</dom-module>