Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2709)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.html

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns
Patch Set: closure Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_page.html b/chrome/browser/resources/settings/internet_page/internet_page.html
index 0570cc08d8598e030cbb49ec551de3df3309b522..7c9a84b5336b85e98af9341e353e5615a7eac79f 100644
--- a/chrome/browser/resources/settings/internet_page/internet_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_page.html
@@ -1,8 +1,9 @@
+<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
<link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_animated_pages.html">
-<link rel="import" href="chrome://md-settings/settings_page/settings_subheader.html">
+<link rel="import" href="chrome://md-settings/settings_page/settings_subpage.html">
<link rel="import" href="chrome://md-settings/settings_shared_css.html">
<link rel="import" href="internet_detail_page.html">
<link rel="import" href="internet_known_networks_page.html">
@@ -20,26 +21,26 @@
networking-private="[[networkingPrivate]]">
</network-summary>
</neon-animatable>
- <neon-animatable id="network-detail">
- <settings-subheader i18n-values="page-title:internetDetailPageTitle">
- </settings-subheader>
- <settings-internet-detail-page
- guid="[[detailGuid]]"
- default-network="[[defaultNetwork]]"
- on-close="onBackTap_"
- networking-private="[[networkingPrivate]]">
- </settings-internet-detail-page>
- </neon-animatable>
- <neon-animatable id="known-networks">
- <settings-subheader
- i18n-values="page-title:internetKnownNetworksPageTitle">
- </settings-subheader>
- <settings-internet-known-networks-page
- network-type="[[knownNetworksType]]"
- on-show-detail="onShowDetail_"
- networking-private="[[networkingPrivate]]">
- </settings-internet-known-networks-page>
- </neon-animatable>
+ <template is="dom-if" name="network-detail">
+ <settings-subpage page-title="[[i18n('internetDetailPageTitle')]]">
+ <settings-internet-detail-page
+ guid="[[detailGuid]]"
+ default-network="[[defaultNetwork]]"
+ on-close="onBackTap_"
+ networking-private="[[networkingPrivate]]">
+ </settings-internet-detail-page>
+ </settings-subpage>
+ </template>
+ <template is="dom-if" name="known-networks">
+ <settings-subpage
+ page-title="[[i18n('internetKnownNetworksPageTitle')]]">
+ <settings-internet-known-networks-page
+ network-type="[[knownNetworksType]]"
+ on-show-detail="onShowDetail_"
+ networking-private="[[networkingPrivate]]">
+ </settings-internet-known-networks-page>
+ </settings-subpage>
+ </template>
</settings-animated-pages>
</template>
<script src="internet_page.js"></script>

Powered by Google App Engine
This is Rietveld 408576698