Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8416)

Unified Diff: chrome/test/data/webui/settings/advanced_page_browsertest.js

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns
Patch Set: closure Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/advanced_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/advanced_page_browsertest.js b/chrome/test/data/webui/settings/advanced_page_browsertest.js
index 0ab9b6e84478f18f4cafa0580db641c8d84c9da1..8582cb06dfc8bcf09b5b01526c6b3b3d346b34db 100644
--- a/chrome/test/data/webui/settings/advanced_page_browsertest.js
+++ b/chrome/test/data/webui/settings/advanced_page_browsertest.js
@@ -23,9 +23,9 @@ SettingsAdvancedPageBrowserTest.prototype = {
// the Settings page can take several seconds to load in a Release build
// and several times that in a Debug build. See https://crbug.com/558434.
GEN('#if defined(MEMORY_SANITIZER) || !defined(NDEBUG)');
-GEN('#define MAYBE_Load DISABLED_Main');
+GEN('#define MAYBE_Load DISABLED_Load');
GEN('#else');
-GEN('#define MAYBE_Load Main');
+GEN('#define MAYBE_Load Load');
GEN('#endif');
TEST_F('SettingsAdvancedPageBrowserTest', 'MAYBE_Load', function() {
@@ -41,15 +41,15 @@ TEST_F('SettingsAdvancedPageBrowserTest', 'MAYBE_Load', function() {
test('advanced pages', function() {
var page = self.getPage('advanced');
- expectTrue(!!self.getSection(page, 'privacy'));
- expectTrue(!!self.getSection(page, 'passwordsAndForms'));
- expectTrue(!!self.getSection(page, 'languages'));
- expectTrue(!!self.getSection(page, 'downloads'));
- expectTrue(!!self.getSection(page, 'reset'));
- if (cr.isChromeOS) {
- expectTrue(!!self.getSection(page, 'dateTime'));
- expectTrue(!!self.getSection(page, 'bluetooth'));
- expectTrue(!!self.getSection(page, 'a11y'));
+ var sections = ['privacy', 'passwordsAndForms', 'languages', 'downloads',
+ 'reset'];
+ if (cr.isChromeOS)
+ sections = sections.concat(['dateTime', 'bluetooth', 'a11y']);
+
+ for (var i = 0; i < sections.length; i++) {
+ var section = self.getSection(page, sections[i]);
+ expectTrue(!!section);
+ self.verifySubpagesHidden(section);
}
});
});

Powered by Google App Engine
This is Rietveld 408576698