Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
haraken, tkent, adamk
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, adamk+blink_chromium.org, rwlbuis, Nils Barth (inactive), Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, nessy, loislo+blink_chromium.org, sof, feature-media-reviews_chromium.org, kojih, vcarbune.chromium, philipj_slow, jsbell+bindings_chromium.org, gasubic, Inactive, watchdog-blink-watchlist_google.com, Mikhail
Visibility:
Public.

Description

Allow the implementation to return references instead of pointers to the bindings Allow the implementation to return references instead of pointers to the bindings. Up until now, this limitation was preventing some refactoring on the implementation side. This CL also makes Element::classList() and Element::dataset() return a reference as a proof of concept, as this method is exposed to the JS. R=haraken, adamk, tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168062

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 32 chunks +32 lines, -32 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-02-26 22:24:20 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-02-26 22:52:06 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-02-27 20:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/182243002/20001
6 years, 9 months ago (2014-02-27 20:01:00 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 00:13:17 UTC) #5
Message was sent while issue was closed.
Change committed as 168062

Powered by Google App Engine
This is Rietveld 408576698