Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp - Issue 182243002: Allow the implementation to return references instead of pointers to the bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

index 5d3b3b8f7f094e2060afadd0417e138433fb76db..59705ad7f969e46c15b0717409b6fb7d1c73ae6d 100644

--- a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

+++ b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

@@ -221,7 +221,7 @@ static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo

return;

if (!result)

return;

- v8SetReturnValueFast(info, result.release(), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);

}

static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)

@@ -285,7 +285,7 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa

return;

if (!result)

return;

- v8SetReturnValueFast(info, result.release(), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);

}

static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »