Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 182243002: Allow the implementation to return references instead of pointers to the bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

index 5d34683132a7fa9b50f2565dfa4a113b9c6274a3..2acbe59c4338dae30c5d3abd0f0b3ed8afa6a4fb 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -74,7 +74,7 @@ template <typename T> void V8_USE(T) { }

static void attr1AttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

TestInterfaceWillBeGarbageCollected* imp = V8TestInterfaceWillBeGarbageCollected::toNative(info.Holder());

- v8SetReturnValueFast(info, imp->attr1(), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(imp->attr1()), imp);

}

static void attr1AttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfacePython.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »