Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2749 matching lines...) Expand 10 before | Expand all | Expand 10 after
2760 } 2760 }
2761 2761
2762 bool Element::matches(const String& selectors, ExceptionState& exceptionState) 2762 bool Element::matches(const String& selectors, ExceptionState& exceptionState)
2763 { 2763 {
2764 SelectorQuery* selectorQuery = document().selectorQueryCache().add(AtomicStr ing(selectors), document(), exceptionState); 2764 SelectorQuery* selectorQuery = document().selectorQueryCache().add(AtomicStr ing(selectors), document(), exceptionState);
2765 if (!selectorQuery) 2765 if (!selectorQuery)
2766 return false; 2766 return false;
2767 return selectorQuery->matches(*this); 2767 return selectorQuery->matches(*this);
2768 } 2768 }
2769 2769
2770 DOMTokenList* Element::classList() 2770 DOMTokenList& Element::classList()
2771 { 2771 {
2772 ElementRareData& rareData = ensureElementRareData(); 2772 ElementRareData& rareData = ensureElementRareData();
2773 if (!rareData.classList()) 2773 if (!rareData.classList())
2774 rareData.setClassList(ClassList::create(this)); 2774 rareData.setClassList(ClassList::create(this));
2775 return rareData.classList(); 2775 return *rareData.classList();
2776 } 2776 }
2777 2777
2778 DOMStringMap* Element::dataset() 2778 DOMStringMap& Element::dataset()
2779 { 2779 {
2780 ElementRareData& rareData = ensureElementRareData(); 2780 ElementRareData& rareData = ensureElementRareData();
2781 if (!rareData.dataset()) 2781 if (!rareData.dataset())
2782 rareData.setDataset(DatasetDOMStringMap::create(this)); 2782 rareData.setDataset(DatasetDOMStringMap::create(this));
2783 return rareData.dataset(); 2783 return *rareData.dataset();
2784 } 2784 }
2785 2785
2786 KURL Element::getURLAttribute(const QualifiedName& name) const 2786 KURL Element::getURLAttribute(const QualifiedName& name) const
2787 { 2787 {
2788 #if !ASSERT_DISABLED 2788 #if !ASSERT_DISABLED
2789 if (elementData()) { 2789 if (elementData()) {
2790 if (const Attribute* attribute = getAttributeItem(name)) 2790 if (const Attribute* attribute = getAttributeItem(name))
2791 ASSERT(isURLAttribute(*attribute)); 2791 ASSERT(isURLAttribute(*attribute));
2792 } 2792 }
2793 #endif 2793 #endif
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
3540 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3540 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3541 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3541 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3542 if (hasTagName(optionTag) || hasTagName(optgroupTag)) 3542 if (hasTagName(optionTag) || hasTagName(optgroupTag))
3543 return false; 3543 return false;
3544 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3544 if (FullscreenElementStack::isActiveFullScreenElement(this))
3545 return false; 3545 return false;
3546 return true; 3546 return true;
3547 } 3547 }
3548 3548
3549 } // namespace WebCore 3549 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698