Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp
index d2fed35bbd5f1eee16eade5a18671407c92ad9ea..211f3e53be3cf122958e1e32d4ecc60662606297 100644
--- a/Source/bindings/tests/results/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/V8TestInterface.cpp
@@ -164,7 +164,7 @@ static void implementsNodeAttributeAttributeGetter(const v8::PropertyCallbackInf
{
TestInterface* imp = V8TestInterface::toNative(info.Holder());
ASSERT(imp);
- v8SetReturnValueFast(info, TestImplements::implementsNodeAttribute(*imp), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsNodeAttribute(*imp)), imp);
}
static void implementsNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -225,7 +225,7 @@ static void implementsRuntimeEnabledNodeAttributeAttributeGetter(const v8::Prope
{
TestInterface* imp = V8TestInterface::toNative(info.Holder());
ASSERT(imp);
- v8SetReturnValueFast(info, TestImplements::implementsRuntimeEnabledNodeAttribute(*imp), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsRuntimeEnabledNodeAttribute(*imp)), imp);
}
static void implementsRuntimeEnabledNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -254,7 +254,7 @@ static void implementsPerContextEnabledNodeAttributeAttributeGetter(const v8::Pr
{
TestInterface* imp = V8TestInterface::toNative(info.Holder());
ASSERT(imp);
- v8SetReturnValueFast(info, TestImplements::implementsPerContextEnabledNodeAttribute(*imp), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsPerContextEnabledNodeAttribute(*imp)), imp);
}
static void implementsPerContextEnabledNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -388,7 +388,7 @@ static void supplementalNodeAttributeGetter(const v8::PropertyCallbackInfo<v8::V
{
TestInterface* imp = V8TestInterface::toNative(info.Holder());
ASSERT(imp);
- v8SetReturnValueFast(info, TestPartialInterface::supplementalNode(*imp), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(TestPartialInterface::supplementalNode(*imp)), imp);
}
#endif // ENABLE(CONDITION_PARTIAL)
@@ -425,7 +425,7 @@ static void Node13AttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& inf
{
TestInterface* imp = V8TestInterface::toNative(info.Holder());
ASSERT(imp);
- v8SetReturnValueFast(info, TestPartialInterface::node13(*imp), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(TestPartialInterface::node13(*imp)), imp);
}
#endif // ENABLE(CONDITION_PARTIAL)
@@ -657,11 +657,11 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (!result0Enabled && !result1Enabled)
return;
if (result0Enabled) {
- v8SetReturnValueFast(info, result0.release(), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result0.release()), imp);
return;
}
if (result1Enabled) {
- v8SetReturnValueFast(info, result1.release(), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result1.release()), imp);
return;
}
v8SetReturnValueNull(info);
« no previous file with comments | « Source/bindings/tests/results/V8TestEventTarget.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698