[Extensions] Convert APIs to use movable types [4]

[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949
Committed: https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73
Cr-Commit-Position: refs/heads/master@{#383157}

[Devlin, 2016-03-23 16:46:45]

Description was changed from

==========
Next

BUG=
==========

to

==========
[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949
==========

[Devlin, 2016-03-23 16:48:36]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-03-23 16:49:20]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-03-23 16:49:21]

(all of these should be independent of one another.)

[lazyboy, 2016-03-23 21:26:58]

lgtm.

https://codereview.chromium.org/1822303002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/downloads/downloads_api.cc (right):

https://codereview.chromium.org/1822303002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/downloads/downloads_api.cc:991: typedef
downloads::HeaderNameValuePair HeaderNameValuePair;
optional nit: can get rid of this typedef since it is used only once now.

[Devlin, 2016-03-24 20:56:26]

https://codereview.chromium.org/1822303002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/downloads/downloads_api.cc (right):

https://codereview.chromium.org/1822303002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/downloads/downloads_api.cc:991: typedef
downloads::HeaderNameValuePair HeaderNameValuePair;
On 2016/03/23 21:26:58, lazyboy wrote:
> optional nit: can get rid of this typedef since it is used only once now.

Done.

[Devlin, 2016-03-24 20:56:31]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-24 20:56:31]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1822303002/#ps40001
(title: "Istiaque's")

[commit-bot: I haz the power, 2016-03-24 20:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822303002/40001

[commit-bot: I haz the power, 2016-03-24 21:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:15:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-03-24 21:17:58]

rdevlin.cronin@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Devlin, 2016-03-24 21:17:59]

+Steven for c/b/chromeos

[stevenjb, 2016-03-24 21:21:23]

Nice. lgtm.

[Devlin, 2016-03-24 21:46:22]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822303002/40001

[commit-bot: I haz the power, 2016-03-24 21:56:32]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949
==========

[commit-bot: I haz the power, 2016-03-24 21:56:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-24 21:57:49]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [4]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- cryptotoken_private.idl
- dashboard_private.json
- data_reduction_proxy.json
- debugger.json
- declarative_content.json
- desktop_capture.json
- dial.idl
- downloads.idl
- downloads_internal.idl
- easy_unlock_private.idl
- echo_private.json
- enterprise_device_attributes.idl
- enterprise_platform_keys.idl
- enterprise_platform_keys_internal.idl
- enterprise_platform_keys_private.json
- extension.json
- feedback_private.idl

BUG=595949

Committed: https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73
Cr-Commit-Position: refs/heads/master@{#383157}
==========

[commit-bot: I haz the power, 2016-03-24 21:57:50]

Patchset 2 (id:??) landed as
https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73
Cr-Commit-Position: refs/heads/master@{#383157}