chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 1822303002: [Extensions] Convert APIs to use movable types [4]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 1822303002: [Extensions] Convert APIs to use movable types [4] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Istiaque's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.h ('k') | chrome/browser/extensions/api/feedback_private/feedback_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index 061742f6e2128bc88ab7ecef3174b3418896c677..1772b044cb6b3809811c17d71bbf010ae55d592d 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -29,6 +29,7 @@

#include "ui/base/webui/web_ui_util.h"

#include "url/url_util.h"

+using extensions::api::feedback_private::SystemInformation;

using feedback::FeedbackData;

namespace {

@@ -235,9 +236,8 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {

new FeedbackData::SystemLogsMap);

SystemInformationList* sys_info = feedback_info.system_information.get();

if (sys_info) {

- for (SystemInformationList::iterator it = sys_info->begin();

- it != sys_info->end(); ++it)

- (*sys_logs.get())[it->get()->key] = it->get()->value;

+ for (const SystemInformation& info : *sys_info)

+ (*sys_logs)[info.key] = info.value;

}

feedback_data->SetAndCompressSystemInfo(std::move(sys_logs));