Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5340)

Unified Diff: chrome/browser/extensions/api/dial/dial_api.cc

Issue 1822303002: [Extensions] Convert APIs to use movable types [4] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Istiaque's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/dial/dial_api.cc
diff --git a/chrome/browser/extensions/api/dial/dial_api.cc b/chrome/browser/extensions/api/dial/dial_api.cc
index a0a36cec301135a25fd5107eef61c055154baf27..7e48a955567c15c5d8b11a0eefb6e605437b3e81 100644
--- a/chrome/browser/extensions/api/dial/dial_api.cc
+++ b/chrome/browser/extensions/api/dial/dial_api.cc
@@ -98,13 +98,11 @@ void DialAPI::OnDialError(const DialRegistry::DialErrorCode code) {
void DialAPI::SendEventOnUIThread(const DialRegistry::DeviceList& devices) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- std::vector<linked_ptr<api::dial::DialDevice> > args;
- for (DialRegistry::DeviceList::const_iterator it = devices.begin();
- it != devices.end(); ++it) {
- linked_ptr<api::dial::DialDevice> api_device =
- make_linked_ptr(new api::dial::DialDevice);
- it->FillDialDevice(api_device.get());
- args.push_back(api_device);
+ std::vector<api::dial::DialDevice> args;
+ for (const DialDeviceData& device : devices) {
+ api::dial::DialDevice api_device;
+ device.FillDialDevice(&api_device);
+ args.push_back(std::move(api_device));
}
scoped_ptr<base::ListValue> results = api::dial::OnDeviceList::Create(args);
scoped_ptr<Event> event(new Event(events::DIAL_ON_DEVICE_LIST,

Powered by Google App Engine
This is Rietveld 408576698