[Extensions] Convert APIs to use movable types [4]

chrome/browser/extensions/api/downloads/downloads_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/downloads/downloads_api.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <set>
 #include <string>
@@ skipping 970 matching lines @@
     if (!net::IsSafePortableRelativePath(creator_suggested_filename)) {
       error_ = errors::kInvalidFilename;
       return false;
     }
   }
 
   if (options.save_as.get())
     download_params->set_prompt(*options.save_as.get());
 
   if (options.headers.get()) {
     typedef downloads::HeaderNameValuePair HeaderNameValuePair;

[lazyboy, 2016/03/23 21:26:58]

optional nit: can get rid of this typedef since it is used only once now.

[Devlin, 2016/03/24 20:56:26]

Done.

-    for (std::vector<linked_ptr<HeaderNameValuePair> >::const_iterator iter =
-         options.headers->begin();
-         iter != options.headers->end();
-         ++iter) {
-      const HeaderNameValuePair& name_value = **iter;
+    for (const HeaderNameValuePair& name_value : *options.headers) {
       if (!net::HttpUtil::IsValidHeaderName(name_value.name)) {
         error_ = errors::kInvalidHeaderName;
         return false;
       }
       if (!net::HttpUtil::IsSafeHeader(name_value.name)) {
         error_ = errors::kInvalidHeaderUnsafe;
         return false;
       }
       if (!net::HttpUtil::IsValidHeaderValue(name_value.value)) {
         error_ = errors::kInvalidHeaderValue;
@@ skipping 896 matching lines @@
     return;
   base::Time now(base::Time::Now());
   int delta = now.ToTimeT() - last_checked_removal_.ToTimeT();
   if (delta <= kFileExistenceRateLimitSeconds)
     return;
   last_checked_removal_ = now;
   manager->CheckForHistoryFilesRemoval();
 }
 
 }  // namespace extensions