Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service.cc

Issue 1822303002: [Extensions] Convert APIs to use movable types [4] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Istiaque's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_service.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.cc b/chrome/browser/extensions/api/feedback_private/feedback_service.cc
index 9bd1e5f13a24bd7a2d3ddd8f1f48bbd7b8330524..13a7cbda759c1e483ff46a69fd6b116d5f9cef5d 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_service.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.cc
@@ -15,6 +15,7 @@
#include "content/public/browser/browser_thread.h"
using content::BrowserThread;
+using extensions::api::feedback_private::SystemInformation;
using feedback::FeedbackData;
namespace extensions {
@@ -28,10 +29,10 @@ void PopulateSystemInfo(SystemInformationList* sys_info_list,
sys_info_value.Set("key", new base::StringValue(key));
sys_info_value.Set("value", new base::StringValue(value));
- linked_ptr<SystemInformation> sys_info(new SystemInformation());
- SystemInformation::Populate(sys_info_value, sys_info.get());
+ SystemInformation sys_info;
+ SystemInformation::Populate(sys_info_value, &sys_info);
- sys_info_list->push_back(sys_info);
+ sys_info_list->push_back(std::move(sys_info));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698