Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 1821053002: [Autofill] Disambiguate similar types before uploading. (Closed)

Created:
4 years, 9 months ago by sebsg
Modified:
4 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Mathieu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the uploads for the new credit card types. Added the DisambiguateUploadTypes method that uses the context from the other fields to disambiguate a field that has multiple upload types. BUG=589535, 589536 TEST=AutofillManagerTest Committed: https://crrev.com/2c0656f3a65e7acf418534c3f1d014e3e023859e Cr-Commit-Position: refs/heads/master@{#382852}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -22 lines) Patch
M components/autofill/core/browser/autofill_manager.h View 2 chunks +19 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 chunks +173 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 5 chunks +186 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/phone_number.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
sebsg
Hi Václav, Could you please take a look when you get the chance? Thanks!
4 years, 9 months ago (2016-03-22 02:38:48 UTC) #7
vabr (Chromium)
Hello Sebastien, LGTM, just nits. Cheers, Vaclav https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc#newcode1924 components/autofill/core/browser/autofill_manager.cc:1924: bool continue_search ...
4 years, 9 months ago (2016-03-22 17:08:10 UTC) #8
sebsg
Could you please take another look? Thanks! https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc#newcode1924 components/autofill/core/browser/autofill_manager.cc:1924: bool continue_search ...
4 years, 9 months ago (2016-03-22 18:30:27 UTC) #9
vabr (Chromium)
LGTM, thanks! Vaclav https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/1821053002/diff/80001/components/autofill/core/browser/autofill_manager.cc#newcode1960 components/autofill/core/browser/autofill_manager.cc:1960: SelectRightNameType(upload_types, &matching_types, On 2016/03/22 18:30:26, sebsg ...
4 years, 9 months ago (2016-03-23 08:41:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821053002/100001
4 years, 9 months ago (2016-03-23 15:41:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 9 months ago (2016-03-23 15:48:53 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 15:50:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c0656f3a65e7acf418534c3f1d014e3e023859e
Cr-Commit-Position: refs/heads/master@{#382852}

Powered by Google App Engine
This is Rietveld 408576698