Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 1821053002: [Autofill] Disambiguate similar types before uploading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index d463edf5c0db87bff31bb5b3ddcbccd2d2016001..b192ae86e35d6dd93ae4817736d1ba01cf541de3 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -31,13 +31,14 @@ enum FieldTypeGroupForMetrics {
GROUP_PHONE,
GROUP_FAX, // Deprecated.
GROUP_EMAIL,
- GROUP_CREDIT_CARD_NAME_FULL,
+ GROUP_CREDIT_CARD_NAME,
GROUP_CREDIT_CARD_NUMBER,
GROUP_CREDIT_CARD_DATE,
GROUP_CREDIT_CARD_TYPE,
GROUP_PASSWORD,
GROUP_ADDRESS_LINE_3,
GROUP_USERNAME,
+ GROUP_STREET_ADDRESS,
NUM_FIELD_TYPE_GROUPS_FOR_METRICS
};
@@ -99,6 +100,8 @@ int GetFieldTypeGroupMetric(ServerFieldType field_type,
case ADDRESS_HOME_LINE3:
group = GROUP_ADDRESS_LINE_3;
break;
+ case ADDRESS_HOME_STREET_ADDRESS:
+ group = GROUP_STREET_ADDRESS;
case ADDRESS_HOME_CITY:
group = GROUP_ADDRESS_CITY;
break;
@@ -130,7 +133,9 @@ int GetFieldTypeGroupMetric(ServerFieldType field_type,
case CREDIT_CARD:
switch (field_type) {
case CREDIT_CARD_NAME_FULL:
- group = GROUP_CREDIT_CARD_NAME_FULL;
+ case CREDIT_CARD_NAME_FIRST:
+ case CREDIT_CARD_NAME_LAST:
+ group = GROUP_CREDIT_CARD_NAME;
break;
case CREDIT_CARD_NUMBER:
group = GROUP_CREDIT_CARD_NUMBER;
« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/credit_card.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698