Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/autofill/core/browser/phone_number.cc

Issue 1821053002: [Autofill] Disambiguate similar types before uploading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/phone_number.cc
diff --git a/components/autofill/core/browser/phone_number.cc b/components/autofill/core/browser/phone_number.cc
index d09117d201814eec96044e7af6457e1786db50bb..59f5e71834b2b3ecd30c4b460331751b5013fd3e 100644
--- a/components/autofill/core/browser/phone_number.cc
+++ b/components/autofill/core/browser/phone_number.cc
@@ -189,18 +189,6 @@ void PhoneNumber::GetMatchingTypes(const base::string16& text,
matching_types->insert(PHONE_HOME_WHOLE_NUMBER);
}
}
-
- // If both PHONE_HOME_CITY_AND_NUMBER and PHONE_HOME_WHOLE_NUMBER are matched,
- // it means there is no country code in the profile's phone number. In that
- // case, we should only return PHONE_HOME_CITY_AND_NUMBER because it's more
- // precise.
- ServerFieldTypeSet::iterator whole_number_iterator =
- matching_types->find(PHONE_HOME_WHOLE_NUMBER);
- if (whole_number_iterator != matching_types->end() &&
- matching_types->find(PHONE_HOME_CITY_AND_NUMBER) !=
- matching_types->end()) {
- matching_types->erase(whole_number_iterator);
- }
}
void PhoneNumber::UpdateCacheIfNeeded(const std::string& app_locale) const {
« no previous file with comments | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698