components/autofill/core/browser/credit_card.cc - Issue 1821053002: [Autofill] Disambiguate similar types before uploading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.cc

Issue 1821053002: [Autofill] Disambiguate similar types before uploading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/credit_card.cc

diff --git a/components/autofill/core/browser/credit_card.cc b/components/autofill/core/browser/credit_card.cc

index 9ea2ee76e9d734426fa39421f6d738f519dc163d..1e7997a6d1ece3a5f11acb7a335162ff31dceb87 100644

--- a/components/autofill/core/browser/credit_card.cc

+++ b/components/autofill/core/browser/credit_card.cc

@@ -641,9 +641,10 @@ bool CreditCard::IsValid() const {

expiration_year_, expiration_month_, base::Time::Now());

}

-// TODO(crbug.com/589536): Upload new credit card types to the server.

void CreditCard::GetSupportedTypes(ServerFieldTypeSet* supported_types) const {

supported_types->insert(CREDIT_CARD_NAME_FULL);

+ supported_types->insert(CREDIT_CARD_NAME_FIRST);

+ supported_types->insert(CREDIT_CARD_NAME_LAST);

supported_types->insert(CREDIT_CARD_NUMBER);

supported_types->insert(CREDIT_CARD_TYPE);

supported_types->insert(CREDIT_CARD_EXP_MONTH);