Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 1821053002: [Autofill] Disambiguate similar types before uploading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 2587 matching lines...) Expand 10 before | Expand all | Expand 10 after
2598 "John Dillinger", "423456789012" /* Visa */, 2598 "John Dillinger", "423456789012" /* Visa */,
2599 "01", "2010"); 2599 "01", "2010");
2600 personal_data_->AddCreditCard(credit_card); 2600 personal_data_->AddCreditCard(credit_card);
2601 2601
2602 // Verify that the web database has been updated and the notification sent. 2602 // Verify that the web database has been updated and the notification sent.
2603 EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged()) 2603 EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
2604 .WillOnce(QuitMainMessageLoop()); 2604 .WillOnce(QuitMainMessageLoop());
2605 base::MessageLoop::current()->Run(); 2605 base::MessageLoop::current()->Run();
2606 2606
2607 personal_data_->GetNonEmptyTypes(&non_empty_types); 2607 personal_data_->GetNonEmptyTypes(&non_empty_types);
2608 EXPECT_EQ(27U, non_empty_types.size()); 2608 EXPECT_EQ(29U, non_empty_types.size());
2609 EXPECT_TRUE(non_empty_types.count(NAME_FIRST)); 2609 EXPECT_TRUE(non_empty_types.count(NAME_FIRST));
2610 EXPECT_TRUE(non_empty_types.count(NAME_MIDDLE)); 2610 EXPECT_TRUE(non_empty_types.count(NAME_MIDDLE));
2611 EXPECT_TRUE(non_empty_types.count(NAME_MIDDLE_INITIAL)); 2611 EXPECT_TRUE(non_empty_types.count(NAME_MIDDLE_INITIAL));
2612 EXPECT_TRUE(non_empty_types.count(NAME_LAST)); 2612 EXPECT_TRUE(non_empty_types.count(NAME_LAST));
2613 EXPECT_TRUE(non_empty_types.count(NAME_FULL)); 2613 EXPECT_TRUE(non_empty_types.count(NAME_FULL));
2614 EXPECT_TRUE(non_empty_types.count(EMAIL_ADDRESS)); 2614 EXPECT_TRUE(non_empty_types.count(EMAIL_ADDRESS));
2615 EXPECT_TRUE(non_empty_types.count(COMPANY_NAME)); 2615 EXPECT_TRUE(non_empty_types.count(COMPANY_NAME));
2616 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_LINE1)); 2616 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_LINE1));
2617 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_LINE2)); 2617 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_LINE2));
2618 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_STREET_ADDRESS)); 2618 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_STREET_ADDRESS));
2619 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_CITY)); 2619 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_CITY));
2620 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_STATE)); 2620 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_STATE));
2621 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_ZIP)); 2621 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_ZIP));
2622 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_COUNTRY)); 2622 EXPECT_TRUE(non_empty_types.count(ADDRESS_HOME_COUNTRY));
2623 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_NUMBER)); 2623 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_NUMBER));
2624 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_CITY_CODE)); 2624 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_CITY_CODE));
2625 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_COUNTRY_CODE)); 2625 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_COUNTRY_CODE));
2626 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_CITY_AND_NUMBER)); 2626 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_CITY_AND_NUMBER));
2627 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_WHOLE_NUMBER)); 2627 EXPECT_TRUE(non_empty_types.count(PHONE_HOME_WHOLE_NUMBER));
2628 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NAME_FULL)); 2628 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NAME_FULL));
2629 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NAME_FIRST));
2630 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NAME_LAST));
2629 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NUMBER)); 2631 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_NUMBER));
2630 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_TYPE)); 2632 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_TYPE));
2631 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_MONTH)); 2633 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_MONTH));
2632 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_2_DIGIT_YEAR)); 2634 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_2_DIGIT_YEAR));
2633 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_4_DIGIT_YEAR)); 2635 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_4_DIGIT_YEAR));
2634 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR)); 2636 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR));
2635 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR)); 2637 EXPECT_TRUE(non_empty_types.count(CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR));
2636 } 2638 }
2637 2639
2638 TEST_F(PersonalDataManagerTest, IncognitoReadOnly) { 2640 TEST_F(PersonalDataManagerTest, IncognitoReadOnly) {
(...skipping 1138 matching lines...) Expand 10 before | Expand all | Expand 10 after
3777 EXPECT_GT(base::TimeDelta::FromMilliseconds(500), 3779 EXPECT_GT(base::TimeDelta::FromMilliseconds(500),
3778 base::Time::Now() - saved_profiles.front()->use_date()); 3780 base::Time::Now() - saved_profiles.front()->use_date());
3779 } 3781 }
3780 3782
3781 // Erase the profiles for the next test. 3783 // Erase the profiles for the next test.
3782 ResetProfiles(); 3784 ResetProfiles();
3783 } 3785 }
3784 } 3786 }
3785 3787
3786 } // namespace autofill 3788 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/credit_card.cc ('k') | components/autofill/core/browser/phone_number.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698