Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1820303002: Revert of switch colorfilters to sk_sp (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/1822623002/ ) Reason for revert: need to fix unguarded makeWithFilter Original issue's description: > switch colorfilters to sk_sp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822623002 > > Committed: https://skia.googlesource.com/skia/+/f809d7687a4fb7b88b651b046da2bc0035d6aa09 TBR=fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1eb81db650d31f50be67b12d60c4f9e7dd08432f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+483 lines, -447 lines) Patch
M bench/BlurRoundRectBench.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M bench/ColorCubeBench.cpp View 3 chunks +12 lines, -4 lines 0 comments Download
M bench/ColorFilterBench.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 3 chunks +29 lines, -15 lines 0 comments Download
M gm/blurredclippedcircle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/color4f.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M gm/colorcube.cpp View 5 chunks +31 lines, -16 lines 0 comments Download
M gm/coloremoji.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 5 chunks +26 lines, -23 lines 0 comments Download
M gm/colorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/emboss.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/fadefilter.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M gm/imagefilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersbase.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/imagefiltersgraph.cpp View 4 chunks +13 lines, -10 lines 0 comments Download
M gm/lumafilter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/megalooper.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/recordopts.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M gm/skbug1719.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/tablecolorfilter.cpp View 5 chunks +24 lines, -23 lines 0 comments Download
M gm/testimagefilters.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M gm/textbloblooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/vertices.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 3 chunks +4 lines, -20 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkColorCubeFilter.h View 2 chunks +1 line, -5 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +8 lines, -13 lines 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +1 line, -5 lines 0 comments Download
M include/effects/SkTableColorFilter.h View 2 chunks +3 lines, -15 lines 0 comments Download
M public.bzl View 2 chunks +1 line, -3 lines 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleColorFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 5 chunks +24 lines, -17 lines 0 comments Download
M src/core/SkBlitter.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkColorFilter.cpp View 4 chunks +16 lines, -18 lines 0 comments Download
M src/core/SkColorFilterShader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.cpp View 2 chunks +10 lines, -12 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkModeColorFilter.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/core/SkModeColorFilter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkRGBAToYUV.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorFilterTest.cpp View 7 chunks +26 lines, -23 lines 0 comments Download
M tests/ColorMatrixTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 10 chunks +23 lines, -18 lines 0 comments Download
M tests/PaintTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordOptsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 4 chunks +18 lines, -15 lines 0 comments Download
M tools/android/SkAndroidSDKCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of switch colorfilters to sk_sp
4 years, 9 months ago (2016-03-22 14:34:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820303002/1
4 years, 9 months ago (2016-03-22 14:34:56 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 14:35:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1eb81db650d31f50be67b12d60c4f9e7dd08432f

Powered by Google App Engine
This is Rietveld 408576698