Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}

Committed: https://crrev.com/340545a9d2c2bf94d93421bbb6bfa40596ae4523
Cr-Commit-Position: refs/heads/master@{#382688}

[sky, 2016-03-21 19:53:56]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
R=ben@chromium.org
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
==========

[sky, 2016-03-21 19:55:13]

I'm TBRing this as it's your patch without the change to connect_test_driver.cc
. Without the exit a DCHECK is triggered in node_channel. I talked with Ken
about the DCHECK and filed a bug.

[sky, 2016-03-21 19:55:19]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-03-21 19:55:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819063002/20001

[commit-bot: I haz the power, 2016-03-21 21:12:46]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-03-21 21:12:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 21:14:06]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

[commit-bot: I haz the power, 2016-03-21 21:14:07]

Patchset 2 (id:??) landed as
https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}

[esprehn, 2016-03-22 00:38:01]

This seems to have made the mojo_apptests go red.

[esprehn, 2016-03-22 00:39:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1821913002/ by esprehn@chromium.org.

The reason for reverting is: Looks like to made the mojo_apptests go red. I
think this is also making MUS tests fail?

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/39128
.

[sky, 2016-03-22 17:12:02]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

[sky, 2016-03-22 19:55:29]

On 2016/03/22 00:39:47, esprehn wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1821913002/ by mailto:esprehn@chromium.org.
> 
> The reason for reverting is: Looks like to made the mojo_apptests go red. I
> think this is also making MUS tests fail?
> 
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/39128
> .

I believe I sorted out all the issues blocking this here
https://codereview.chromium.org/1827453002/ and
https://codereview.chromium.org/1819413002/ . The only change since last
patchset is to update resource_provider_unittests, which was added since my last
commit attempt. I'm going to try and land again.

[sky, 2016-03-22 19:55:33]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-03-22 19:55:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819063002/40001

[commit-bot: I haz the power, 2016-03-22 21:44:24]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

[commit-bot: I haz the power, 2016-03-22 21:44:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-22 21:46:04]

Description was changed from

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
==========

to

==========
Quit the message loop by default in ShellConnectionLost when ApplicationRunner
is used

This was originally at https://codereview.chromium.org/1814223002/ , but Ben is
out and
I need this for tests, so I'm taking over.

BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org

Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}

Committed: https://crrev.com/340545a9d2c2bf94d93421bbb6bfa40596ae4523
Cr-Commit-Position: refs/heads/master@{#382688}
==========

[commit-bot: I haz the power, 2016-03-22 21:46:05]

Patchset 3 (id:??) landed as
https://crrev.com/340545a9d2c2bf94d93421bbb6bfa40596ae4523
Cr-Commit-Position: refs/heads/master@{#382688}