mash/browser_driver/browser_driver_application_delegate.cc - Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/browser_driver/browser_driver_application_delegate.cc

Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge and update resourceproviderunittest Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mash/browser_driver/browser_driver_application_delegate.h ('k') | mash/example/window_type_launcher/window_type_launcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/browser_driver/browser_driver_application_delegate.cc

diff --git a/mash/browser_driver/browser_driver_application_delegate.cc b/mash/browser_driver/browser_driver_application_delegate.cc

index d30225ec8d1c58710c000c14fa23c7d7a4250a8d..cc6bbdcefae08f176cd4d7173104f01f1c72224c 100644

--- a/mash/browser_driver/browser_driver_application_delegate.cc

+++ b/mash/browser_driver/browser_driver_application_delegate.cc

@@ -67,10 +67,10 @@ bool BrowserDriverApplicationDelegate::AcceptConnection(

return true;

}

-void BrowserDriverApplicationDelegate::ShellConnectionLost() {

+bool BrowserDriverApplicationDelegate::ShellConnectionLost() {

// Prevent the code in AddAccelerators() from keeping this app alive.

binding_.set_connection_error_handler(base::Bind(&DoNothing));

- base::MessageLoop::current()->QuitWhenIdle();

+ return true;

}

void BrowserDriverApplicationDelegate::OnAccelerator(