components/resource_provider/resource_provider_app.cc - Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/resource_provider_app.cc

Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge and update resourceproviderunittest Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/resource_provider/resource_provider_app.h ('k') | components/resource_provider/resource_provider_test_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/resource_provider/resource_provider_app.cc

diff --git a/components/resource_provider/resource_provider_app.cc b/components/resource_provider/resource_provider_app.cc

index 18b4e42f3a6ea005fa72cb6ad30b2b728792f73a..cd16a9889432c95bc516c82612aa3fc6952c4063 100644

--- a/components/resource_provider/resource_provider_app.cc

+++ b/components/resource_provider/resource_provider_app.cc

@@ -37,11 +37,6 @@ bool ResourceProviderApp::AcceptConnection(mojo::Connection* connection) {

return true;

}

-void ResourceProviderApp::ShellConnectionLost() {

- // TODO: This should exit cleanly.

- _exit(1);

void ResourceProviderApp::Create(

mojo::Connection* connection,

mojo::InterfaceRequest<ResourceProvider> request) {

« no previous file with comments | « components/resource_provider/resource_provider_app.h ('k') | components/resource_provider/resource_provider_test_app.cc » ('j') | no next file with comments »