mash/browser_driver/browser_driver_application_delegate.h - Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/browser_driver/browser_driver_application_delegate.h

Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge and update resourceproviderunittest Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | mash/browser_driver/browser_driver_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/browser_driver/browser_driver_application_delegate.h

diff --git a/mash/browser_driver/browser_driver_application_delegate.h b/mash/browser_driver/browser_driver_application_delegate.h

index f517a763e6be1138eae03d000e0ec58424ac7664..0c057797a6abbf67051a5afecfd8aa3c2d5e292b 100644

--- a/mash/browser_driver/browser_driver_application_delegate.h

+++ b/mash/browser_driver/browser_driver_application_delegate.h

@@ -31,7 +31,7 @@ class BrowserDriverApplicationDelegate : public mojo::ShellClient,

void Initialize(mojo::Connector* connector, const mojo::Identity& identity,

uint32_t id) override;

bool AcceptConnection(mojo::Connection* connection) override;

- void ShellConnectionLost() override;

+ bool ShellConnectionLost() override;

// mus::mojom::AcceleratorHandler:

void OnAccelerator(uint32_t id, mus::mojom::EventPtr event) override;

« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | mash/browser_driver/browser_driver_application_delegate.cc » ('j') | no next file with comments »