mojo/shell/background/tests/test_service.cc - Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/background/tests/test_service.cc

Issue 1819063002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge and update resourceproviderunittest Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/background/tests/test_service.cc

diff --git a/mojo/shell/background/tests/test_service.cc b/mojo/shell/background/tests/test_service.cc

index d030a814340064955baf1723ebfd40f547807fb2..e69640d6fd92a7dd43689fe7df033d516dc2f1a4 100644

--- a/mojo/shell/background/tests/test_service.cc

+++ b/mojo/shell/background/tests/test_service.cc

@@ -25,8 +25,8 @@ class TestClient : public ShellClient,

connection->AddInterface(this);

return true;

}

- void ShellConnectionLost() override {

- base::MessageLoop::current()->QuitWhenIdle();

+ bool ShellConnectionLost() override {

+ return true;

}

// InterfaceFactory<mojom::TestService>:

« no previous file with comments | « mojo/services/tracing/tracing_app.cc ('k') | mojo/shell/public/cpp/lib/application_runner.cc » ('j') | no next file with comments »