Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1817903002: Make more of content pass "gn check" (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, tdresser+watch_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make more of content pass "gn check" Adds dependencies and makes some deps public so more of content passes include checking. This adds 25 targets. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c15ed73a0bb7161c52e1fde97bd2bf3e6534d78b Cr-Commit-Position: refs/heads/master@{#382430}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : fixes #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -21 lines) Patch
M .gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 5 chunks +13 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 3 chunks +16 lines, -4 lines 0 comments Download
M content/public/browser/desktop_media_id.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 3 chunks +19 lines, -0 lines 0 comments Download
M content/public/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
brettw
4 years, 9 months ago (2016-03-20 22:32:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817903002/1
4 years, 9 months ago (2016-03-20 22:32:40 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/83901) android_chromium_gn_compile_dbg on ...
4 years, 9 months ago (2016-03-20 22:35:49 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817903002/20001
4 years, 9 months ago (2016-03-21 18:14:57 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/38767)
4 years, 9 months ago (2016-03-21 18:24:06 UTC) #15
Dirk Pranke
lgtm but I have some questions ... https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUILD.gn File content/public/app/BUILD.gn (right): https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUILD.gn#newcode39 content/public/app/BUILD.gn:39: "//content/public/gpu:gpu_sources", It ...
4 years, 9 months ago (2016-03-21 19:08:10 UTC) #17
brettw
https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUILD.gn File content/public/app/BUILD.gn (right): https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUILD.gn#newcode39 content/public/app/BUILD.gn:39: "//content/public/gpu:gpu_sources", No but this follows the content naming scheme ...
4 years, 9 months ago (2016-03-21 20:44:27 UTC) #18
brettw
fixes
4 years, 9 months ago (2016-03-21 20:44:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817903002/40001
4 years, 9 months ago (2016-03-21 20:45:24 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/7270) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 20:48:04 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817903002/60001
4 years, 9 months ago (2016-03-21 22:07:37 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-21 23:14:37 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 23:16:46 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c15ed73a0bb7161c52e1fde97bd2bf3e6534d78b
Cr-Commit-Position: refs/heads/master@{#382430}

Powered by Google App Engine
This is Rietveld 408576698