Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/public/common/BUILD.gn

Issue 1817903002: Make more of content pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/child/BUILD.gn ('k') | content/public/gpu/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/BUILD.gn
diff --git a/content/public/common/BUILD.gn b/content/public/common/BUILD.gn
index 9075452a68dd0ddb74335af5d5599432945769bf..39a95fdbeabc512bdf28f8912d78ff8cdc7e5595 100644
--- a/content/public/common/BUILD.gn
+++ b/content/public/common/BUILD.gn
@@ -36,7 +36,13 @@ source_set("content_descriptors") {
sources = [
"content_descriptors.h",
]
+
+ # The header uses V8_USE_EXTERNAL_STARTUP_DATA.
public_configs = [ "//v8:external_startup_data" ]
+
+ deps = [
+ "//ipc",
+ ]
}
# Forces static linking for targets using the static_switches constants, even
@@ -91,14 +97,26 @@ source_set("common_sources") {
"//url/ipc:url_ipc",
]
deps = [
+ "//ipc",
+ "//ipc/mojo",
+ "//media",
+ "//mojo/common",
"//net",
+ "//ppapi/c",
"//skia",
+ "//storage/common",
"//third_party/WebKit/public:blink_headers",
"//third_party/icu",
+ "//ui/accessibility",
"//ui/base",
"//ui/gfx",
+ "//ui/gfx/ipc",
+ "//ui/surface",
]
+ # //content/common needs to include public headers.
+ allow_circular_includes_from = [ "//content/common" ]
+
if (!enable_plugins) {
sources -= [
"pepper_plugin_info.cc",
@@ -132,6 +150,7 @@ buildflag_header("features") {
source_set("feature_h264_with_openh264_ffmpeg") {
deps = [
":features",
+ "//base",
]
sources = [
"feature_h264_with_openh264_ffmpeg.cc",
« no previous file with comments | « content/public/child/BUILD.gn ('k') | content/public/gpu/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698