Make more of content pass "gn check"

content/public/app/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # App different than the regular content subcomponents (see comments in
 # //content/BUILD.gn) because it has to support the browser/child process split
 # (the "both" target include both browser and child process files and is used
 # for testing).
 #
 # In non-component mode, browser, child, and both all follow the same structure:
@@ skipping 18 matching lines @@
   "content_main_delegate.h",
   "content_main_runner.h",
   "sandbox_helper_win.h",
 ]
 
 public_app_shared_deps = [
   "//base",
   "//base:i18n",
   "//content:export",
   "//content/public/common:common_sources",
+  "//content/public/gpu:gpu_sources",

[Dirk Pranke, 2016/03/21 19:08:10]

It seems a bit confusing to have a target called '*_sources' that only contains
headers.  Of course, some of the _sources targets do actually contain sources,
but do we have a policy on calling something _sources vs _headers?

[brettw, 2016/03/21 20:44:27]

No but this follows the content naming scheme where there are targets called
//content/public/foo for public deps, and //content/public/foo:foo_sources for
internal ones (so the component build works).

The fact that the GPU one has no actual source files is incidental to this
scheme.

+  "//content/public/plugin:plugin_sources",
+  "//content/public/renderer:renderer_sources",
+  "//content/public/utility:utility_sources",
 ]
 
 if (is_component_build) {
   source_set("both_sources") {
     # Only the main content shared library can pull this in.
     visibility = [ "//content:content" ]
 
     sources = public_app_shared_sources
 
     configs += [ "//content:content_implementation" ]
@@ skipping 81 matching lines @@
         ":both",
       ]
     }
     group("child") {
       deps = [
         ":both",
       ]
     }
   }
 }