Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: content/public/common/BUILD.gn

Issue 1817903002: Make more of content pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//content/common/common.gni") 8 import("//content/common/common.gni")
9 import("//mojo/public/tools/bindings/mojom.gni") 9 import("//mojo/public/tools/bindings/mojom.gni")
10 import("//third_party/webrtc/build/webrtc.gni") 10 import("//third_party/webrtc/build/webrtc.gni")
(...skipping 15 matching lines...) Expand all
26 # header-only dependency, without bringing in all of content. 26 # header-only dependency, without bringing in all of content.
27 source_set("result_codes") { 27 source_set("result_codes") {
28 sources = [ 28 sources = [
29 "result_codes.h", 29 "result_codes.h",
30 ] 30 ]
31 } 31 }
32 32
33 # This target allows other targets to depend on content_descriptors.h which is 33 # This target allows other targets to depend on content_descriptors.h which is
34 # a header-only dependency, without bringing in all of content. 34 # a header-only dependency, without bringing in all of content.
35 source_set("content_descriptors") { 35 source_set("content_descriptors") {
36 # This header includes some other headers for constants, but we explicitly
37 # don't want to link anything else into here so exempt from checking.
38 check_includes = false
Dirk Pranke 2016/03/21 19:08:10 it looks like this just includes build/build_confi
brettw 2016/03/21 20:44:27 Hm, I screwed this up. I just depended on //ipc he
39
36 sources = [ 40 sources = [
37 "content_descriptors.h", 41 "content_descriptors.h",
38 ] 42 ]
39 public_configs = [ "//v8:external_startup_data" ] 43 public_configs = [ "//v8:external_startup_data" ]
40 } 44 }
41 45
42 # Forces static linking for targets using the static_switches constants, even 46 # Forces static linking for targets using the static_switches constants, even
43 # in the component build. This config makes it impossible to use the static 47 # in the component build. This config makes it impossible to use the static
44 # switches target and use the rest of content at the same time, because the 48 # switches target and use the rest of content at the same time, because the
45 # component export flags won't be consistent. 49 # component export flags won't be consistent.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 ] 88 ]
85 89
86 public_configs = [ "//v8:external_startup_data" ] 90 public_configs = [ "//v8:external_startup_data" ]
87 91
88 public_deps = [ 92 public_deps = [
89 "//content/common", 93 "//content/common",
90 "//mojo/public/cpp/bindings", 94 "//mojo/public/cpp/bindings",
91 "//url/ipc:url_ipc", 95 "//url/ipc:url_ipc",
92 ] 96 ]
93 deps = [ 97 deps = [
98 "//ipc",
99 "//ipc/mojo",
100 "//media",
101 "//mojo/common",
94 "//net", 102 "//net",
103 "//ppapi/c",
95 "//skia", 104 "//skia",
105 "//storage/common",
96 "//third_party/WebKit/public:blink_headers", 106 "//third_party/WebKit/public:blink_headers",
97 "//third_party/icu", 107 "//third_party/icu",
108 "//ui/accessibility",
98 "//ui/base", 109 "//ui/base",
99 "//ui/gfx", 110 "//ui/gfx",
111 "//ui/gfx/ipc",
112 "//ui/surface",
100 ] 113 ]
101 114
115 # //content/common needs to include public headers.
116 allow_circular_includes_from = [ "//content/common" ]
117
102 if (!enable_plugins) { 118 if (!enable_plugins) {
103 sources -= [ 119 sources -= [
104 "pepper_plugin_info.cc", 120 "pepper_plugin_info.cc",
105 "pepper_plugin_info.h", 121 "pepper_plugin_info.h",
106 ] 122 ]
107 } 123 }
108 124
109 if (enable_webrtc) { 125 if (enable_webrtc) {
110 sources += [ 126 sources += [
111 "webrtc_ip_handling_policy.cc", 127 "webrtc_ip_handling_policy.cc",
(...skipping 13 matching lines...) Expand all
125 141
126 buildflag_header("features") { 142 buildflag_header("features") {
127 header = "features.h" 143 header = "features.h"
128 144
129 flags = [ "RTC_USE_H264=$rtc_use_h264" ] 145 flags = [ "RTC_USE_H264=$rtc_use_h264" ]
130 } 146 }
131 147
132 source_set("feature_h264_with_openh264_ffmpeg") { 148 source_set("feature_h264_with_openh264_ffmpeg") {
133 deps = [ 149 deps = [
134 ":features", 150 ":features",
151 "//base",
135 ] 152 ]
136 sources = [ 153 sources = [
137 "feature_h264_with_openh264_ffmpeg.cc", 154 "feature_h264_with_openh264_ffmpeg.cc",
138 "feature_h264_with_openh264_ffmpeg.h", 155 "feature_h264_with_openh264_ffmpeg.h",
139 ] 156 ]
140 } 157 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698