Make more of content pass "gn check"

content/public/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/features.gni")
 import("//content/common/common.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//third_party/webrtc/build/webrtc.gni")
@@ skipping 15 matching lines @@
 # header-only dependency, without bringing in all of content.
 source_set("result_codes") {
   sources = [
     "result_codes.h",
   ]
 }
 
 # This target allows other targets to depend on content_descriptors.h which is
 # a header-only dependency, without bringing in all of content.
 source_set("content_descriptors") {
+  # This header includes some other headers for constants, but we explicitly
+  # don't want to link anything else into here so exempt from checking.
+  check_includes = false

[Dirk Pranke, 2016/03/21 19:08:10]

it looks like this just includes build/build_config.h and ipc/ipc_descriptors.h
.

For the latter, why not split that into a separate targets?

For the former, why don't we get complaints all over the place for files that
are including build_config.h but not declaring it?

[brettw, 2016/03/21 20:44:27]

Hm, I screwed this up. I just depended on //ipc here which should be fine. For
some reason I thought this was more complicated.

+
   sources = [
     "content_descriptors.h",
   ]
   public_configs = [ "//v8:external_startup_data" ]
 }
 
 # Forces static linking for targets using the static_switches constants, even
 # in the component build. This config makes it impossible to use the static
 # switches target and use the rest of content at the same time, because the
 # component export flags won't be consistent.
@@ skipping 38 matching lines @@
   ]
 
   public_configs = [ "//v8:external_startup_data" ]
 
   public_deps = [
     "//content/common",
     "//mojo/public/cpp/bindings",
     "//url/ipc:url_ipc",
   ]
   deps = [
+    "//ipc",
+    "//ipc/mojo",
+    "//media",
+    "//mojo/common",
     "//net",
+    "//ppapi/c",
     "//skia",
+    "//storage/common",
     "//third_party/WebKit/public:blink_headers",
     "//third_party/icu",
+    "//ui/accessibility",
     "//ui/base",
     "//ui/gfx",
+    "//ui/gfx/ipc",
+    "//ui/surface",
   ]
 
+  # //content/common needs to include public headers.
+  allow_circular_includes_from = [ "//content/common" ]
+
   if (!enable_plugins) {
     sources -= [
       "pepper_plugin_info.cc",
       "pepper_plugin_info.h",
     ]
   }
 
   if (enable_webrtc) {
     sources += [
       "webrtc_ip_handling_policy.cc",
@@ skipping 13 matching lines @@
 
 buildflag_header("features") {
   header = "features.h"
 
   flags = [ "RTC_USE_H264=$rtc_use_h264" ]
 }
 
 source_set("feature_h264_with_openh264_ffmpeg") {
   deps = [
     ":features",
+    "//base",
   ]
   sources = [
     "feature_h264_with_openh264_ffmpeg.cc",
     "feature_h264_with_openh264_ffmpeg.h",
   ]
 }