Make more of content pass "gn check"

Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c15ed73a0bb7161c52e1fde97bd2bf3e6534d78b
Cr-Commit-Position: refs/heads/master@{#382430}

[brettw, 2016-03-20 22:30:25]

Description was changed from

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking
==========

to

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brettw, 2016-03-20 22:30:25]

Description was changed from

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brettw, 2016-03-20 22:31:37]

Description was changed from

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking. This adds 51 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brettw, 2016-03-20 22:31:37]

brettw@chromium.org changed reviewers:
+ dpranke@google.com

[brettw, 2016-03-20 22:32:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 22:32:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817903002/1

[brettw, 2016-03-20 22:32:58]

Description was changed from

==========
Mkae more of content pass "gn check"

Adds dependencies and makes some deps public so more of content/common passes
include checking. This adds 51 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 51 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-20 22:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-20 22:35:49]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-03-21 18:14:19]

Description was changed from

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 51 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brettw, 2016-03-21 18:14:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 18:14:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817903002/20001

[commit-bot: I haz the power, 2016-03-21 18:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 18:24:06]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Dirk Pranke, 2016-03-21 19:08:09]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-21 19:08:10]

lgtm but I have some questions ...

https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUIL...
File content/public/app/BUILD.gn (right):

https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUIL...
content/public/app/BUILD.gn:39: "//content/public/gpu:gpu_sources",
It seems a bit confusing to have a target called '*_sources' that only contains
headers.  Of course, some of the _sources targets do actually contain sources,
but do we have a policy on calling something _sources vs _headers?

https://codereview.chromium.org/1817903002/diff/20001/content/public/common/B...
File content/public/common/BUILD.gn (right):

https://codereview.chromium.org/1817903002/diff/20001/content/public/common/B...
content/public/common/BUILD.gn:38: check_includes = false
it looks like this just includes build/build_config.h and ipc/ipc_descriptors.h
.

For the latter, why not split that into a separate targets?

For the former, why don't we get complaints all over the place for files that
are including build_config.h but not declaring it?

[brettw, 2016-03-21 20:44:27]

https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUIL...
File content/public/app/BUILD.gn (right):

https://codereview.chromium.org/1817903002/diff/20001/content/public/app/BUIL...
content/public/app/BUILD.gn:39: "//content/public/gpu:gpu_sources",
No but this follows the content naming scheme where there are targets called
//content/public/foo for public deps, and //content/public/foo:foo_sources for
internal ones (so the component build works).

The fact that the GPU one has no actual source files is incidental to this
scheme.

https://codereview.chromium.org/1817903002/diff/20001/content/public/common/B...
File content/public/common/BUILD.gn (right):

https://codereview.chromium.org/1817903002/diff/20001/content/public/common/B...
content/public/common/BUILD.gn:38: check_includes = false
Hm, I screwed this up. I just depended on //ipc here which should be fine. For
some reason I thought this was more complicated.

[brettw, 2016-03-21 20:44:49]

fixes

[brettw, 2016-03-21 20:44:49]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-21 20:44:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1817903002/#ps40001
(title: "fixes")

[commit-bot: I haz the power, 2016-03-21 20:45:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817903002/40001

[commit-bot: I haz the power, 2016-03-21 20:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:48:04]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-03-21 22:07:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-21 22:07:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1817903002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-21 22:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817903002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817903002/60001

[commit-bot: I haz the power, 2016-03-21 23:14:36]

Description was changed from

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-21 23:14:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-21 23:16:45]

Description was changed from

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make more of content pass "gn check"

Adds dependencies and makes some deps public so more of content passes include
checking. This adds 25 targets.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c15ed73a0bb7161c52e1fde97bd2bf3e6534d78b
Cr-Commit-Position: refs/heads/master@{#382430}
==========

[commit-bot: I haz the power, 2016-03-21 23:16:46]

Patchset 4 (id:??) landed as
https://crrev.com/c15ed73a0bb7161c52e1fde97bd2bf3e6534d78b
Cr-Commit-Position: refs/heads/master@{#382430}