Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC (Closed)

Created:
4 years, 9 months ago by jungshik at Google
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set U_NOEXCEPT to empty to avoid C4577 from MSVC ICU in Chromium is compiled with exception disabled [1], but U_NOEXCEPT is set to 'noexcept' regardless of whether _HAS_EXCEPTION is set to 0 or (in source/common/unicode/platform.h ). [2]. Set U_NOEXCEPT to empty in our build files to avoid this issue. [1] http://bugs.icu-project.org/trac/ticket/8343 [2] http://bugs.icu-project.org/trac/ticket/12406 BUG=575007 TEST=Build on Windows with MSVS 2015 succeeds. R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/8a6c927be5132b592ca609ff598c3290ba1dbe19

Patch Set 1 #

Patch Set 2 : long lines wrapped #

Patch Set 3 : TODO added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M icu.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jungshik at Google
Ick. I didn't notice that this hadn't been sent out. Can you take a look? ...
4 years, 9 months ago (2016-03-18 21:56:36 UTC) #4
Nico
It'd be good if ICU did this automatically on Windows based on _HAS_EXCEPTIONS. Until that's ...
4 years, 9 months ago (2016-03-18 22:00:30 UTC) #5
jungshik at Google
On 2016/03/18 22:00:30, Nico wrote: > It'd be good if ICU did this automatically on ...
4 years, 9 months ago (2016-03-18 23:22:14 UTC) #6
jungshik at Google
4 years, 9 months ago (2016-03-18 23:31:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8a6c927be5132b592ca609ff598c3290ba1dbe19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698