icu.gyp - Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: TODO added Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: icu.gyp

diff --git a/icu.gyp b/icu.gyp

index 648f679a76dfbe9d7b40fb5cb47d9367189361e5..bd5125e9b6f1e8ebe52bf4262afc15f98d79438f 100644

--- a/icu.gyp

+++ b/icu.gyp

@@ -20,6 +20,11 @@

# We don't use ICU plugins and dyload is only necessary for them.

# NaCl-related builds also fail looking for dlfcn.h when it's enabled.

'U_ENABLE_DYLOAD=0',

+ # With exception disabled, MSVC emits C4577 warning on coming across

+ # 'noexcept'. See http://bugs.icu-project.org/trac/ticket/12406

+ # TODO(jshin): Remove this when updating to a newer version with this

+ # fixed.

+ 'U_NOEXCEPT=',

'defines': [

« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »