Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: BUILD.gn

Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: TODO added Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/rules.gni") 8 import("//build/config/android/rules.gni")
9 } 9 }
10 10
11 # Meta target that includes both icuuc and icui18n. Most targets want both. 11 # Meta target that includes both icuuc and icui18n. Most targets want both.
12 # You can depend on the individually if you need to. 12 # You can depend on the individually if you need to.
13 group("icu") { 13 group("icu") {
14 public_deps = [ 14 public_deps = [
15 ":icui18n", 15 ":icui18n",
16 ":icuuc", 16 ":icuuc",
17 ] 17 ]
18 } 18 }
19 19
20 # Shared config used by ICU and all dependents. 20 # Shared config used by ICU and all dependents.
21 config("icu_config") { 21 config("icu_config") {
22 defines = [ 22 defines = [
23 # Tell ICU to not insert |using namespace icu;| into its headers, 23 # Tell ICU to not insert |using namespace icu;| into its headers,
24 # so that chrome's source explicitly has to use |icu::|. 24 # so that chrome's source explicitly has to use |icu::|.
25 "U_USING_ICU_NAMESPACE=0", 25 "U_USING_ICU_NAMESPACE=0",
26 26
27 # We don't use ICU plugins and dyload is only necessary for them. 27 # We don't use ICU plugins and dyload is only necessary for them.
28 # NaCl-related builds also fail looking for dlfcn.h when it's enabled. 28 # NaCl-related builds also fail looking for dlfcn.h when it's enabled.
29 "U_ENABLE_DYLOAD=0", 29 "U_ENABLE_DYLOAD=0",
30
31 # With exception disabled, MSVC emits C4577 warning on coming across
32 # 'noexcept'. See http://bugs.icu-project.org/trac/ticket/12406
33 # TODO(jshin): Remove this when updating to a newer version with this fixed.
34 "U_NOEXCEPT=",
30 ] 35 ]
31 36
32 if (!is_component_build) { 37 if (!is_component_build) {
33 defines += [ "U_STATIC_IMPLEMENTATION" ] 38 defines += [ "U_STATIC_IMPLEMENTATION" ]
34 } 39 }
35 40
36 include_dirs = [ 41 include_dirs = [
37 "source/common", 42 "source/common",
38 "source/i18n", 43 "source/i18n",
39 ] 44 ]
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 sources = [ 620 sources = [
616 "android/icudtl_dat.S", 621 "android/icudtl_dat.S",
617 ] 622 ]
618 } else { 623 } else {
619 assert(false, "No icu data for this platform") 624 assert(false, "No icu data for this platform")
620 } 625 }
621 defines = [ "U_HIDE_DATA_SYMBOL" ] 626 defines = [ "U_HIDE_DATA_SYMBOL" ]
622 } 627 }
623 } 628 }
624 } 629 }
OLDNEW
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698