Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: icu.gyp

Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: TODO added Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
11 'icu_use_data_file_flag%': 0, 11 'icu_use_data_file_flag%': 0,
12 'want_separate_host_toolset%': 1, 12 'want_separate_host_toolset%': 1,
13 }, 13 },
14 'target_defaults': { 14 'target_defaults': {
15 'direct_dependent_settings': { 15 'direct_dependent_settings': {
16 'defines': [ 16 'defines': [
17 # Tell ICU to not insert |using namespace icu;| into its headers, 17 # Tell ICU to not insert |using namespace icu;| into its headers,
18 # so that chrome's source explicitly has to use |icu::|. 18 # so that chrome's source explicitly has to use |icu::|.
19 'U_USING_ICU_NAMESPACE=0', 19 'U_USING_ICU_NAMESPACE=0',
20 # We don't use ICU plugins and dyload is only necessary for them. 20 # We don't use ICU plugins and dyload is only necessary for them.
21 # NaCl-related builds also fail looking for dlfcn.h when it's enabled. 21 # NaCl-related builds also fail looking for dlfcn.h when it's enabled.
22 'U_ENABLE_DYLOAD=0', 22 'U_ENABLE_DYLOAD=0',
23 # With exception disabled, MSVC emits C4577 warning on coming across
24 # 'noexcept'. See http://bugs.icu-project.org/trac/ticket/12406
25 # TODO(jshin): Remove this when updating to a newer version with this
26 # fixed.
27 'U_NOEXCEPT=',
23 ], 28 ],
24 }, 29 },
25 'defines': [ 30 'defines': [
26 'U_USING_ICU_NAMESPACE=0', 31 'U_USING_ICU_NAMESPACE=0',
27 'HAVE_DLOPEN=0', 32 'HAVE_DLOPEN=0',
28 # Only build encoding coverters and detectors necessary for HTML5. 33 # Only build encoding coverters and detectors necessary for HTML5.
29 'UCONFIG_ONLY_HTML_CONVERSION=1', 34 'UCONFIG_ONLY_HTML_CONVERSION=1',
30 # No dependency on the default platform encoding. 35 # No dependency on the default platform encoding.
31 # Will cut down the code size. 36 # Will cut down the code size.
32 'U_CHARSET_IS_UTF8=1', 37 'U_CHARSET_IS_UTF8=1',
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 }, 602 },
598 'includes': [ 603 'includes': [
599 '../../build/shim_headers.gypi', 604 '../../build/shim_headers.gypi',
600 ], 605 ],
601 'toolsets': ['target'], 606 'toolsets': ['target'],
602 }, 607 },
603 ], # targets 608 ], # targets
604 }], 609 }],
605 ], # conditions 610 ], # conditions
606 } 611 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698