Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: BUILD.gn

Issue 1816673002: Set U_NOEXCEPT to empty to avoid C4577 from MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: TODO added Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index adfa81f119bca4daa5857b70212283158a52e88d..557eec7172bf43fc1a82ff689aa2557f72996d35 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -27,6 +27,11 @@ config("icu_config") {
# We don't use ICU plugins and dyload is only necessary for them.
# NaCl-related builds also fail looking for dlfcn.h when it's enabled.
"U_ENABLE_DYLOAD=0",
+
+ # With exception disabled, MSVC emits C4577 warning on coming across
+ # 'noexcept'. See http://bugs.icu-project.org/trac/ticket/12406
+ # TODO(jshin): Remove this when updating to a newer version with this fixed.
+ "U_NOEXCEPT=",
]
if (!is_component_build) {
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698