[DevTools] Move getFunctionDetails to native

[DevTools] Move getFunctionDetails to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7
Cr-Commit-Position: refs/heads/master@{#382180}

[kozy, 2016-03-18 19:07:27]

Dmitry, please take a look.

[dgozman, 2016-03-18 23:27:55]

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js (right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:52: 0:
"global",
0 -> ScopeType.Global, etc.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:446:
scopeTypes[j] = scopeTypes[i];
Wrap here to string.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1209:
InjectedScript.CallFrameProxy._scopeTypeNames = {
Remove this, make JavaScriptCallFrame return string.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:698: if
(!value->IsObject() || !value->IsFunction()) {
Only function.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:699:
*errorString = "Cannot resolve function by id";
Value with given id is not a function.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:763:
*errorString = "Cannot resolve function by id.";
revert

[kozy, 2016-03-19 00:40:23]

All done!

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js (right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:52: 0:
"global",
On 2016/03/18 23:27:55, dgozman wrote:
> 0 -> ScopeType.Global, etc.

Done.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js:446:
scopeTypes[j] = scopeTypes[i];
On 2016/03/18 23:27:55, dgozman wrote:
> Wrap here to string.

Done.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1209:
InjectedScript.CallFrameProxy._scopeTypeNames = {
On 2016/03/18 23:27:55, dgozman wrote:
> Remove this, make JavaScriptCallFrame return string.

Done.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:698: if
(!value->IsObject() || !value->IsFunction()) {
On 2016/03/18 23:27:55, dgozman wrote:
> Only function.

Done.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:699:
*errorString = "Cannot resolve function by id";
On 2016/03/18 23:27:55, dgozman wrote:
> Value with given id is not a function.

Done.

https://codereview.chromium.org/1815753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:763:
*errorString = "Cannot resolve function by id.";
On 2016/03/18 23:27:55, dgozman wrote:
> revert

Done.

[dgozman, 2016-03-19 00:51:12]

lgtm

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1220: *
@param {number} scopeType
string

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(left):

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:71: if
(value->IsString() && v8::Local<v8::String>::Cast(value)->Length())
This check is gone in new code. Should we bring it back?

[kozy, 2016-03-19 01:11:12]

All done!

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1220: *
@param {number} scopeType
On 2016/03/19 00:51:12, dgozman wrote:
> string

Done.

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(left):

https://codereview.chromium.org/1815753002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:71: if
(value->IsString() && v8::Local<v8::String>::Cast(value)->Length())
On 2016/03/19 00:51:12, dgozman wrote:
> This check is gone in new code. Should we bring it back?

I achieve the same behavior by using toProtocolStringWithTypeCheck.

[kozy, 2016-03-19 03:06:36]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-19 03:06:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1815753002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-19 03:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815753002/40001

[commit-bot: I haz the power, 2016-03-19 04:32:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-19 04:42:19]

Description was changed from

==========
[DevTools] Move getFunctionDetails to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move getFunctionDetails to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7
Cr-Commit-Position: refs/heads/master@{#382180}
==========

[commit-bot: I haz the power, 2016-03-19 04:42:20]

Patchset 3 (id:??) landed as
https://crrev.com/1cc5174af365db7552713f15ed159c5dabe6b8d7
Cr-Commit-Position: refs/heads/master@{#382180}