third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp - Issue 1815753002: [DevTools] Move getFunctionDetails to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

Issue 1815753002: [DevTools] Move getFunctionDetails to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-get-internal-properties

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

index a23891100008a41531b316817034d6d82c2067ff..e70d7b5c90d56525e882882ad09dcbea368ed4cc 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

@@ -130,13 +130,13 @@ v8::Local<v8::Value> JavaScriptCallFrame::scopeChain() const

return result;

}

-int JavaScriptCallFrame::scopeType(int scopeIndex) const

+v8::Local<v8::String> JavaScriptCallFrame::scopeType(int scopeIndex) const

{

v8::MicrotasksScope microtasks(m_isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);

v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame);

v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "scopeType")));

v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked());

- return scopeType->Get(scopeIndex)->Int32Value();

+ return scopeType->Get(scopeIndex)->ToString();

}

v8::Local<v8::String> JavaScriptCallFrame::scopeName(int scopeIndex) const

@@ -144,8 +144,8 @@ v8::Local<v8::String> JavaScriptCallFrame::scopeName(int scopeIndex) const

v8::MicrotasksScope microtasks(m_isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);

v8::Local<v8::Object> callFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame);

v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(callFrame->Get(toV8StringInternalized(m_isolate, "scopeName")));

- v8::Local<v8::Array> scopeType = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked());

- return scopeType->Get(scopeIndex)->ToString();

+ v8::Local<v8::Array> scopeName = v8::Local<v8::Array>::Cast(func->Call(m_isolate->GetCurrentContext(), callFrame, 0, nullptr).ToLocalChecked());

+ return scopeName->Get(scopeIndex)->ToString();

}

v8::Local<v8::Value> JavaScriptCallFrame::scopeStartLocation(int scopeIndex) const