third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h - Issue 1815753002: [DevTools] Move getFunctionDetails to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 1815753002: [DevTools] Move getFunctionDetails to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-get-internal-properties

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

index 5c2ac0650bb222005cf04d19fd71de771b17a516..f4f8eba399fa5617821b91e4cc5aba3e89f4e84f 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

@@ -57,7 +57,7 @@ public:

int functionColumn() const;

v8::Local<v8::Value> scopeChain() const;

- int scopeType(int scopeIndex) const;

+ v8::Local<v8::String> scopeType(int scopeIndex) const;

v8::Local<v8::String> scopeName(int scopeIndex) const;

v8::Local<v8::Value> scopeStartLocation(int scopeIndex) const;

v8::Local<v8::Value> scopeEndLocation(int scopeIndex) const;