[DevTools] Move getInternalProperties to native

[DevTools] Move getInternalProperties to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b
Cr-Commit-Position: refs/heads/master@{#382172}

[kozy, 2016-03-18 18:10:40]

Dmitry, please take a look!

[dgozman, 2016-03-18 20:52:21]

https://codereview.chromium.org/1818473002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:713:
*errorString = "Could not find object with type Object and given id";
Improve this error string.

[kozy, 2016-03-18 22:53:16]

All done. Please take a look!

https://codereview.chromium.org/1818473002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:713:
*errorString = "Could not find object with type Object and given id";
On 2016/03/18 20:52:21, dgozman wrote:
> Improve this error string.

Done.

[dgozman, 2016-03-18 23:07:50]

lgtm

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:244: if
(!object->IsSymbol() && errorString->isEmpty() && !exceptionDetails->isJust() &&
!accessorPropertiesOnly.fromMaybe(false)) {
if (error) return with error;
if (isSymbol) return;

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:247:
return;
errorString!

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:491:
*context = injectedScript->context();
Should not set context if object was not found.

[kozy, 2016-03-18 23:58:34]

All done.

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:244: if
(!object->IsSymbol() && errorString->isEmpty() && !exceptionDetails->isJust() &&
!accessorPropertiesOnly.fromMaybe(false)) {
On 2016/03/18 23:07:49, dgozman wrote:
> if (error) return with error;
> if (isSymbol) return;

Done.

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:247:
return;
On 2016/03/18 23:07:49, dgozman wrote:
> errorString!

Done.

https://codereview.chromium.org/1818473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:491:
*context = injectedScript->context();
On 2016/03/18 23:07:50, dgozman wrote:
> Should not set context if object was not found.

Done.

[kozy, 2016-03-19 00:16:47]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-19 00:16:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1818473002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-19 00:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:17:51]

This CL has an open dependency (Issue 1809073003 Patch 100001). Please resolve
the dependency and try again.

[kozy, 2016-03-19 00:21:36]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:22:32]

This CL has an open dependency (Issue 1809073003 Patch 100001). Please resolve
the dependency and try again.

[kozy, 2016-03-19 00:31:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:32:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818473002/40001

[dgozman, 2016-03-19 00:44:43]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2016-03-19 00:45:59]

https://codereview.chromium.org/1818473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:246: if
(!errorString->isEmpty() || exceptionDetails->isJust() ||
accessorPropertiesOnly.fromMaybe(false))
Check error first, before checking for symbol.

[kozy, 2016-03-19 01:17:43]

All done!

https://codereview.chromium.org/1818473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1818473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:246: if
(!errorString->isEmpty() || exceptionDetails->isJust() ||
accessorPropertiesOnly.fromMaybe(false))
On 2016/03/19 00:45:58, dgozman wrote:
> Check error first, before checking for symbol.

Done.

[kozy, 2016-03-19 01:17:47]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-19 01:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1818473002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-19 01:18:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818473002/60001

[kozy, 2016-03-19 01:25:04]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-03-19 01:25:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-19 01:25:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1818473002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-19 01:25:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818473002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818473002/80001

[commit-bot: I haz the power, 2016-03-19 02:41:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-19 02:46:07]

Description was changed from

==========
[DevTools] Move getInternalProperties to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move getInternalProperties to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b
Cr-Commit-Position: refs/heads/master@{#382172}
==========

[commit-bot: I haz the power, 2016-03-19 02:46:09]

Patchset 5 (id:??) landed as
https://crrev.com/f6cac8c2524beae96fbc7bf3e037a2f2c6302a2b
Cr-Commit-Position: refs/heads/master@{#382172}