[DevTools] Move getFunctionDetails to native

third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/inspector_protocol/Values.h"
 #include "platform/v8_inspector/IgnoreExceptionsScope.h"
 #include "platform/v8_inspector/InjectedScript.h"
@@ skipping 669 matching lines @@
 void V8DebuggerAgentImpl::getFunctionDetails(ErrorString* errorString, const String16& functionId, OwnPtr<FunctionDetails>* details)
 {
     if (!checkEnabled(errorString))
         return;
     OwnPtr<RemoteObjectId> remoteId = RemoteObjectId::parse(errorString, functionId);
     if (!remoteId)
         return;
     InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript(errorString, remoteId.get());
     if (!injectedScript)
         return;
-    injectedScript->getFunctionDetails(errorString, functionId, details);
+
+    v8::HandleScope scope(m_isolate);
+    v8::Local<v8::Context> context = injectedScript->context();
+    v8::Context::Scope contextScope(context);
+
+    v8::Local<v8::Value> value;
+    if (!injectedScript->findObject(errorString, *remoteId, &value))
+        return;
+    if (!value->IsObject() || !value->IsFunction()) {

[dgozman, 2016/03/18 23:27:55]

Only function.

[kozy, 2016/03/19 00:40:23]

Done.

+        *errorString = "Cannot resolve function by id";

[dgozman, 2016/03/18 23:27:55]

Value with given id is not a function.

[kozy, 2016/03/19 00:40:23]

Done.

+        return;
+    }
+    v8::Local<v8::Function> function = value.As<v8::Function>();
+
+    v8::Local<v8::Value> scopesValue;
+    v8::Local<v8::Array> scopes;
+    String16 objectGroupName = injectedScript->objectGroupName(*remoteId);
+    if (m_debugger->functionScopes(function).ToLocal(&scopesValue) && scopesValue->IsArray()) {
+        scopes = scopesValue.As<v8::Array>();
+        for (size_t i = 0; i < scopes->Length(); ++i) {
+            v8::Local<v8::Value> scope;
+            if (!scopes->Get(injectedScript->context(), i).ToLocal(&scope) || !scope->IsObject()) {
+                *errorString = "Internal error";
+                return;
+            }
+            if (!injectedScript->wrapObjectProperty(errorString, scope.As<v8::Object>(), toV8String(injectedScript->isolate(), "object"), objectGroupName))
+                return;
+        }
+    }
+
+    OwnPtr<protocol::Debugger::Location> location = protocol::Debugger::Location::create()
+        .setScriptId(String16::number(function->ScriptId()))
+        .setLineNumber(function->GetScriptLineNumber())
+        .setColumnNumber(function->GetScriptColumnNumber()).build();
+
+    OwnPtr<FunctionDetails> functionDetails = FunctionDetails::create()
+        .setLocation(location.release())
+        .setFunctionName(toProtocolStringWithTypeCheck(function->GetDebugName()))
+        .setIsGenerator(function->IsGeneratorFunction()).build();
+
+    if (!scopes.IsEmpty()) {
+        protocol::ErrorSupport errorSupport;
+        OwnPtr<protocol::Array<protocol::Debugger::Scope>> scopeChain = protocol::Array<protocol::Debugger::Scope>::parse(toProtocolValue(injectedScript->context(), scopes).get(), &errorSupport);
+        if (errorSupport.hasErrors()) {
+            *errorString = "Internal error";
+            return;
+        }
+        functionDetails->setScopeChain(scopeChain.release());
+    }
+
+    *details = functionDetails.release();
 }
 
 void V8DebuggerAgentImpl::getGeneratorObjectDetails(ErrorString* errorString, const String16& objectId, OwnPtr<GeneratorObjectDetails>* outDetails)
 {
     if (!checkEnabled(errorString))
         return;
     OwnPtr<RemoteObjectId> remoteId = RemoteObjectId::parse(errorString, objectId);
     if (!remoteId)
         return;
     InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript(errorString, remoteId.get());
     if (!injectedScript)
         return;
 
     v8::HandleScope scope(m_isolate);
     v8::Local<v8::Context> context = injectedScript->context();
     v8::Context::Scope contextScope(context);
 
     v8::Local<v8::Object> object;
     v8::Local<v8::Value> value;
     if (!injectedScript->findObject(errorString, *remoteId, &value))
         return;
     if (!value->IsObject() || !value->ToObject(context).ToLocal(&object)) {
-        *errorString = "Could not find object with type Object and given id";
+        *errorString = "Cannot resolve function by id.";

[dgozman, 2016/03/18 23:27:55]

revert

[kozy, 2016/03/19 00:40:23]

Done.

         return;
     }
 
     v8::Local<v8::Object> detailsObject;
     v8::Local<v8::Value> detailsValue = debugger().generatorObjectDetails(object);
     if (!detailsValue->IsObject() || !detailsValue->ToObject(context).ToLocal(&detailsObject)) {
         *errorString = "Internal error";
         return;
     }
 
@@ skipping 850 matching lines @@
     m_scripts.clear();
     m_blackboxedPositions.clear();
     m_breakpointIdToDebuggerBreakpointIds.clear();
     resetAsyncCallTracker();
     m_promiseTracker->clear();
     if (m_frontend)
         m_frontend->globalObjectCleared();
 }
 
 } // namespace blink