added support for glMinSampleShading

added support for glMinSampleShading
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812223002

Committed: https://skia.googlesource.com/skia/+/28ef445d2e55ada7a45fd74e9248b4f22b16e061

[ethannicholas, 2016-03-18 15:30:59]

Description was changed from

==========
added support for glMinSampleShading
==========

to

==========
added support for glMinSampleShading
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-03-18 16:59:19]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 16:59:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/20001

[ethannicholas, 2016-03-18 17:58:54]

Patchset #2 (id:20001) has been deleted

[ethannicholas, 2016-03-18 18:09:18]

Patchset #2 (id:40001) has been deleted

[ethannicholas, 2016-03-18 18:10:59]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 18:11:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/60001

[commit-bot: I haz the power, 2016-03-18 18:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:23:45]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-03-22 18:16:28]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 18:16:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/80001

[commit-bot: I haz the power, 2016-03-22 18:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 18:34:38]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[ethannicholas, 2016-03-23 19:04:35]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 19:04:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/100001

[ethannicholas, 2016-03-23 19:14:11]

ethannicholas@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[ethannicholas, 2016-03-23 19:14:12]

Prerequisite for the new MSAA renderer. For some reason I'm having issues with
glMinSampleShading on Linux -- I'm going to get to the bottom of that, but for
the time being I've added a workaround.

[egdaniel, 2016-03-23 19:46:28]

high level thought before diving into any of this, where's vulkan?

[ethannicholas, 2016-03-23 19:47:30]

On 2016/03/23 19:46:28, egdaniel wrote:
> high level thought before diving into any of this, where's vulkan?

I had planned to worry about it in a followup patch.

[egdaniel, 2016-03-23 19:58:35]

On 2016/03/23 19:47:30, ethannicholas wrote:
> On 2016/03/23 19:46:28, egdaniel wrote:
> > high level thought before diving into any of this, where's vulkan?
> 
> I had planned to worry about it in a followup patch.

Should be minimal amount of work to add to this CL and I feel like it should go
in with this one:

In GrVkCaps::initGrCaps, set the cap with features.sampleRateShading

In GrVkPipeline::setup_multisample_state, queury the caps and GP for setting
multisampleInfo->sampleShadingEnable, and GP for
multisampleInfo->minSampleShading.

That should be all that is needed.

[bsalomon, 2016-03-23 19:58:37]

I'm wondering if we want to expose this (at the Gr level) as simply a boolean.
That is, either we run at pixel rate or we run at sample rate. What does Vulkan
support?

[ethannicholas, 2016-03-23 20:00:25]

On 2016/03/23 19:58:37, bsalomon wrote:
> I'm wondering if we want to expose this (at the Gr level) as simply a boolean.
> That is, either we run at pixel rate or we run at sample rate. What does
Vulkan
> support?

I didn't see any particular reason to remove the capability to do less than that
-- I can easily envision (say) seeing a benefit at 4 samples / pixel but not
wanting to go all the way to 16x for a particular shader.

AFAIK Vulkan exposes the same interface.

[bsalomon, 2016-03-23 21:14:44]

Description was changed from

==========
added support for glMinSampleShading
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
added support for glMinSampleShading
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-23 21:14:44]

bsalomon@google.com changed reviewers:
+ brianosman@google.com

[bsalomon, 2016-03-23 21:15:34]

So Brian, Greg, and I spent a while digging through the various GL extensions
and looking at what D3D offers. It seems like a all-or-nothing approach will buy
us the widest support. Also, some the ES_shader_multisample_interpolation
extension and D3D exposes this at the shading language level by modifying the
varying declaration with a qualifier. We have thoughts about how to do a
minimalist cap that could be supported across all these variations and how a GP
should opt into it. Given the time it's probably too late for a VC, let's chat
tomorrow morning.

[ethannicholas, 2016-03-24 14:47:42]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 14:47:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/140001

[commit-bot: I haz the power, 2016-03-24 15:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 15:03:44]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[ethannicholas, 2016-03-24 15:27:38]

Patchset #6 (id:140001) has been deleted

[ethannicholas, 2016-03-24 15:28:07]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 15:28:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/160001

[commit-bot: I haz the power, 2016-03-24 15:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 15:40:54]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-03-24 16:38:40]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 16:38:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/180001

[commit-bot: I haz the power, 2016-03-24 16:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 16:56:19]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-03-24 18:51:45]

Patchset #8 (id:200001) has been deleted

[ethannicholas, 2016-03-24 18:59:26]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 18:59:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/220001

[commit-bot: I haz the power, 2016-03-24 19:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 19:16:58]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-03-24 20:41:01]

This has the (compiling, but otherwise untested) Vulkan changes, plus the rename
of minSampleShading to sampleShading and a few miscellaneous other changes.

[egdaniel, 2016-03-24 22:20:05]

Generally the vulkan stuff all looks fine with me. However, Jim is landing a
change, https://codereview.chromium.org/1832613003/, which will slightly change
up how the caps will check for the sample shading feature. I believe in his
change he has set up all the hooks for you, you would just need to follow the
pattern of dual src blending in the caps on how to check availability. You
should just coordinate with Jim with who lands first.

[bsalomon, 2016-03-25 15:40:40]

lgtm modulo Greg's comment re Jim's change.

[ethannicholas, 2016-03-25 16:00:20]

Patchset #9 (id:240001) has been deleted

[ethannicholas, 2016-03-25 16:03:43]

Patchset #9 (id:260001) has been deleted

[ethannicholas, 2016-03-25 16:05:13]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-03-25 16:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1812223002/#ps280001
(title: "updated for Jim's change")

[commit-bot: I haz the power, 2016-03-25 16:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812223002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812223002/280001

[commit-bot: I haz the power, 2016-03-25 16:26:06]

Description was changed from

==========
added support for glMinSampleShading
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
added support for glMinSampleShading
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/28ef445d2e55ada7a45fd74e9248b4f22b16e061
==========

[commit-bot: I haz the power, 2016-03-25 16:26:07]

Committed patchset #9 (id:280001) as
https://skia.googlesource.com/skia/+/28ef445d2e55ada7a45fd74e9248b4f22b16e061