Pass shelf instances, not root windows, for ash context menus.

Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/953caf1fc83c06ef7a4da9661f3350faec8a82f6
Cr-Commit-Position: refs/heads/master@{#381849}

[msw, 2016-03-17 19:01:56]

Description was changed from

==========
Pass shelf instances, not root windows, for ash context menus.

Avoids most window->shelf lookup calls.
Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

[msw, 2016-03-17 19:04:37]

Hey Scott, please take a look; thanks!

https://codereview.chromium.org/1812013003/diff/20001/ash/shelf/shelf_alignme...
File ash/shelf/shelf_alignment_menu.cc (right):

https://codereview.chromium.org/1812013003/diff/20001/ash/shelf/shelf_alignme...
ash/shelf/shelf_alignment_menu.cc:57:
shell->SetShelfAlignment(SHELF_ALIGNMENT_LEFT, root_window);
Shell::SetShelfAlignment triggers ShellObserver::OnShelfAlignmentChanged.
We should improve that pattern, but probably not in this CL.

[msw, 2016-03-17 19:04:44]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 19:05:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812013003/20001

[commit-bot: I haz the power, 2016-03-17 19:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 19:23:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-03-17 19:42:33]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 19:43:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812013003/40001

[commit-bot: I haz the power, 2016-03-17 20:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:24:54]

Dry run: This issue passed the CQ dry run.

[msw, 2016-03-17 22:55:06]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 22:55:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812013003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812013003/60001

[msw, 2016-03-17 22:56:47]

Description was changed from

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-03-17 23:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:17:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2016-03-17 23:20:01]

LGTM

[msw, 2016-03-17 23:52:42]

The CQ bit was checked by msw@chromium.org

[msw, 2016-03-17 23:52:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1812013003/#ps80001
(title: "Call OnShelfAlignmentChanged after LayoutShelf.")

[commit-bot: I haz the power, 2016-03-17 23:53:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812013003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812013003/80001

[commit-bot: I haz the power, 2016-03-18 00:33:37]

Description was changed from

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-03-18 00:33:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-18 00:34:31]

Description was changed from

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Pass shelf instances, not root windows, for ash context menus.

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/953caf1fc83c06ef7a4da9661f3350faec8a82f6
Cr-Commit-Position: refs/heads/master@{#381849}
==========

[commit-bot: I haz the power, 2016-03-18 00:34:32]

Patchset 5 (id:??) landed as
https://crrev.com/953caf1fc83c06ef7a4da9661f3350faec8a82f6
Cr-Commit-Position: refs/heads/master@{#381849}