Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: ash/shell_delegate.h

Issue 1812013003: Pass shelf instances, not root windows, for ash context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call OnShelfAlignmentChanged after LayoutShelf. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell_delegate.h
diff --git a/ash/shell_delegate.h b/ash/shell_delegate.h
index cd36fd43dca37aa7f8afd1263b931b591bdb6893..65696887ae573c569f4668410deb71724607d4af 100644
--- a/ash/shell_delegate.h
+++ b/ash/shell_delegate.h
@@ -42,6 +42,7 @@ class ShelfDelegate;
class ShelfModel;
class SystemTrayDelegate;
class UserWallpaperDelegate;
+class Shelf;
struct ShelfItem;
class ASH_EXPORT VirtualKeyboardStateObserver {
@@ -132,9 +133,9 @@ class ASH_EXPORT ShellDelegate {
// Creates a media delegate. Shell takes ownership of the delegate.
virtual MediaDelegate* CreateMediaDelegate() = 0;
- // Creates a menu model for the |root_window| and optional shelf |item|.
+ // Creates a menu model for the |shelf| and optional shelf |item|.
// If |item| is null, this creates a context menu for the desktop or shelf.
- virtual ui::MenuModel* CreateContextMenu(aura::Window* root_window,
+ virtual ui::MenuModel* CreateContextMenu(ash::Shelf* shelf,
const ash::ShelfItem* item) = 0;
// Creates a GPU support object. Shell takes ownership of the object.
« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/test_shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698