Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: ash/shelf/shelf_layout_manager.h

Issue 1812013003: Pass shelf instances, not root windows, for ash context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call OnShelfAlignmentChanged after LayoutShelf. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_alignment_menu.cc ('k') | ash/shelf/shelf_layout_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_layout_manager.h
diff --git a/ash/shelf/shelf_layout_manager.h b/ash/shelf/shelf_layout_manager.h
index 3f21f0041cf8aa6d306b4fe814da2dbcbec3e0e9..ae4a28143d41668867b43a4a745710b546ac68d7 100644
--- a/ash/shelf/shelf_layout_manager.h
+++ b/ash/shelf/shelf_layout_manager.h
@@ -90,16 +90,11 @@ class ASH_EXPORT ShelfLayoutManager
return auto_hide_behavior_;
}
- // Sets the alignment. Returns true if the alignment got changed. If nothing
- // has visually be changed, false will be returned. This can happen if either
- // the alignment was already set, or the shelf is currently locked and cannot
- // be changed at this time. In the latter case the change will be performed
- // once the shelf gets unlocked.
- bool SetAlignment(ShelfAlignment alignment);
+ // Sets the alignment; changes are delayed if the screen is locked.
+ void SetAlignment(ShelfAlignment alignment);
// Returns the desired alignment for the current state, either the user's
- // set alignment (alignment_) or SHELF_ALIGNMENT_BOTTOM when the screen
- // is locked.
+ // selected alignment or SHELF_ALIGNMENT_BOTTOM when the screen is locked.
ShelfAlignment GetAlignment() const;
void set_workspace_controller(WorkspaceController* controller) {
@@ -127,8 +122,7 @@ class ASH_EXPORT ShelfLayoutManager
return user_work_area_bounds_;
}
- // Stops any animations and sets the bounds of the shelf and status
- // widgets.
+ // Stops any animations and sets the bounds of the shelf and status widgets.
void LayoutShelf();
// Returns shelf visibility state based on current value of auto hide
« no previous file with comments | « ash/shelf/shelf_alignment_menu.cc ('k') | ash/shelf/shelf_layout_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698